Re: [PATCH v17 10/16] util/log: Add -d tb_stats

[Richard Henderson <richard.henderson@linaro.org>]

On 10/10/23 05:34, Philippe Mathieu-Daudé wrote:
> On 3/10/23 20:30, Richard Henderson wrote:
>> From: Fei Wu <fei2.wu@intel.com>
>>
>> Enable TBStatistics collection from startup.
>>
>> Signed-off-by: Vanderson M. do Rosario <vandersonmr2@gmail.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Fei Wu <fei2.wu@intel.com>
>> [rth: Change "tb_stats_foo" to "tb_stats:foo"]
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   stubs/tb-stats.c  | 16 ++++++++++++++++
>>   util/log.c        | 36 +++++++++++++++++++++++++++++++-----
>>   stubs/meson.build |  1 +
>>   3 files changed, 48 insertions(+), 5 deletions(-)
>>   create mode 100644 stubs/tb-stats.c
>>
>> diff --git a/stubs/tb-stats.c b/stubs/tb-stats.c
>> new file mode 100644
>> index 0000000000..ceaa1622ce
>> --- /dev/null
>> +++ b/stubs/tb-stats.c
>> @@ -0,0 +1,16 @@
>> +/*
>> + * TB Stats Stubs
>> + *
>> + * Copyright (c) 2019
>> + * Written by Alex Bennée <alex.bennee@linaro.org>
>> + *
>> + * This code is licensed under the GNU GPL v2, or later.
>> + */
>> +
>> +
>> +#include "qemu/osdep.h"
>> +#include "tcg/tb-stats.h"
>> +
>> +void tb_stats_init(uint32_t flags)
>> +{
>> +}
> 
> We don't need this stub anymore.

Certainly we do, within the tools and tests.


r~