From: David Hildenbrand <david@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] tests/functional: fix race in virtio balloon test
Date: Fri, 7 Mar 2025 09:04:08 +0100 [thread overview]
Message-ID: <b4921d1d-6d68-45c9-83a7-6cf4f30ceedb@redhat.com> (raw)
In-Reply-To: <20250304183340.3749797-1-berrange@redhat.com>
On 04.03.25 19:33, Daniel P. Berrangé wrote:
> There are two race conditions in the recently added virtio balloon
> test
>
> * The /dev/vda device node is not ready
> * The virtio-balloon driver has not issued the first stats refresh
>
> To fix the former, monitor dmesg for a line about 'vda'.
>
> To fix the latter, retry the stats query until seeing fresh data.
>
> Adding 'quiet' to the kernel command line reduces serial output
> which otherwise slows boot, making it less likely to hit the former
> race too.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-03-07 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 18:33 [PATCH] tests/functional: fix race in virtio balloon test Daniel P. Berrangé
2025-03-05 7:58 ` Thomas Huth
2025-03-05 12:25 ` Philippe Mathieu-Daudé
2025-03-06 17:42 ` Thomas Huth
2025-03-06 19:23 ` Thomas Huth
2025-03-07 8:02 ` Daniel P. Berrangé
2025-03-07 8:04 ` David Hildenbrand [this message]
2025-04-02 16:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4921d1d-6d68-45c9-83a7-6cf4f30ceedb@redhat.com \
--to=david@redhat.com \
--cc=berrange@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).