From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D47FCC433B4 for ; Mon, 19 Apr 2021 18:27:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2353C60FE4 for ; Mon, 19 Apr 2021 18:27:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2353C60FE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYYcZ-0007ek-RT for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 14:27:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYYZb-0006WQ-BJ for qemu-devel@nongnu.org; Mon, 19 Apr 2021 14:24:39 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:37782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYYZZ-0003nZ-Si for qemu-devel@nongnu.org; Mon, 19 Apr 2021 14:24:39 -0400 Received: by mail-pg1-x52b.google.com with SMTP id p2so9391079pgh.4 for ; Mon, 19 Apr 2021 11:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=P9JcEs8oySBw5uinY7JwsMWOr1xj+luiYwH7dH9G1q4=; b=zroldLjJk7lpmkbl7J3Wo0vJq7CFxwx9S71EfTF5gyegbJZGrvLA+h4lWdPJc50NAw QbUh/IgpkQcY8FOJeBdiVR/pzO3f16KyV2r7uZQKmAckceR4gzw0Dzu2SRiQPtQM8AN/ hEVl7uGk83+R0yqJSAWpYgXPFH1CTI8/mrLuKWRZmPf3O4xQBdsp7de8EQUkhIOhxwlx PylWFXvUai/9JDaGthF4LhjxhEtmdH63c0lnU3ue7ukdHBZCNqAS5s3Yr9Na1X1OqA2V +G/cIU+RBz8vpo13O6IrpmmQrkzxs60PuyoqdYJoEZvHbkC0dSoWy2zRnCsn74aidOQl ohZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P9JcEs8oySBw5uinY7JwsMWOr1xj+luiYwH7dH9G1q4=; b=HiDJ1DfiOEWWmFo1IcERxQEmEMghZPmpdiWK30iA/whBgAZw8WiEZj64itjlHeuJEB g5MFb7a5/21ho5Hus/cdLKoQXGPsA8sGd/92XzTg9JaT9rmS1+dPOjkGph9r047iRvdY rOBbuw713VA4swMNRHFq2/5gR4Ibja2DeKSOz+9pstLvEZ/NzAhpHqCW6OVfh3EiCUr7 yfWttRLcN23fhvrz7xDqirYryz+nQMoNjbbWpm1aXxFO2fsSUU3UhVqWUj3D2zL1ItUs gFJh6FGaXyY//ilmpT49V7u4ttu+MBJTu/JDuibbqRTo1KZRT4s6eNbDkbO4NP5DtSEx KLvA== X-Gm-Message-State: AOAM531nRHCvxY4/O725ZF2Y2qqHXurdJo8c9MSZyO7gqZVco5za0sZS g3uDm4QsEsfC/JEdkhwdn++27Q== X-Google-Smtp-Source: ABdhPJw67hrqLUVziZ0eH3KoNPQLMbH6wxwxbEFVgLolB/jKfnqOMhcJldDqmbBWENtSgjggo7kSXw== X-Received: by 2002:a05:6a00:1687:b029:253:f417:4dba with SMTP id k7-20020a056a001687b0290253f4174dbamr21097696pfc.5.1618856676134; Mon, 19 Apr 2021 11:24:36 -0700 (PDT) Received: from [192.168.64.62] (50-78-183-178-static.hfc.comcastbusiness.net. [50.78.183.178]) by smtp.gmail.com with ESMTPSA id p126sm12726888pfb.32.2021.04.19.11.24.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 11:24:35 -0700 (PDT) Subject: Re: [PATCH v4 06/30] target/arm: Move mode specific TB flags to tb->cs_base To: Peter Maydell References: <20210416185959.1520974-1-richard.henderson@linaro.org> <20210416185959.1520974-7-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Mon, 19 Apr 2021 11:24:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/19/21 10:08 AM, Peter Maydell wrote: > Don't you also need to make assert_hflags_rebuild_correctly() > check flags2 now ? Oops, yes. Thanks. r~