qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu block <qemu-block@nongnu.org>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	den@openvz.org, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] QCOW2 support for LZO compression
Date: Mon, 26 Jun 2017 12:20:23 +0200	[thread overview]
Message-ID: <b498b622-2aa8-3cfc-112d-a8f931d2f08f@kamp.de> (raw)
In-Reply-To: <20170626101204.GF495@redhat.com>

Am 26.06.2017 um 12:12 schrieb Daniel P. Berrange:
> On Mon, Jun 26, 2017 at 12:08:01PM +0200, Peter Lieven wrote:
>> Am 26.06.2017 um 11:57 schrieb Kevin Wolf:
>>> Am 26.06.2017 um 11:20 hat Peter Lieven geschrieben:
>>>>> So he chose a different algorithm (zstd). When I asked, he posted a
>>>>> comparison of algorithms (however a generic one and not measured in the
>>>>> context of qemu) that suggests that LZO would be slightly faster, but
>>>>> have a considerable worse compression ratio with the settings that were
>>>>> benchmarked.
>>>> My idea to choose LZO was that it is widely available and available in
>>>> any distro you can think of. We already have probing for it in configure.
>>>> My concern with ZSTD would be that it seems there are no packages
>>>> available for most distros and that it seems to be multi-threaded. I don't
>>>> know if this will cause any trouble?
>>> The availability and that we already link against LZO is a good point. I
>>> think we want to avoid a situation where compressed qcow2 files can't be
>>> read by binaries of popular distributions - after all, downloadable
>>> images are an important use case for compressed images.
>> As long as the default remains gzip I don't see any issues. If you choose
>> a different algorithm, you should know what you are doing.
> The problem comes if Debian were to choose to only link in ZSTD, and RHEL
> were choose to only link LZO. Images distributed by one distro, with this
> new compression would be unusuable on other distros. So whatever compression
> format we choose to add should be something we are confident that all distros
> will be happy enabling by default. This favours libraries are already widely
> included in distros, especially if QEMU already links to them indirectly.

This is very strong argument for LZO. I checked with Debian 9 and Ubuntu 16.04
they have liblzo installed in the base system. I think maybe for btrfs compression support.

Peter

  reply	other threads:[~2017-06-26 10:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0f83a15d-66b0-36aa-e5a4-d03cd37757c9@kamp.de>
2017-06-26  8:28 ` [Qemu-devel] QCOW2 support for LZO compression Kevin Wolf
2017-06-26  9:20   ` Peter Lieven
2017-06-26  9:33     ` Denis V. Lunev
2017-06-26  9:56       ` Peter Lieven
2017-06-26 10:16       ` Laszlo Ersek
2017-06-26 10:23         ` Denis V. Lunev
2017-06-26 10:41         ` Peter Lieven
2017-06-26  9:57     ` Kevin Wolf
2017-06-26 10:08       ` Peter Lieven
2017-06-26 10:12         ` Daniel P. Berrange
2017-06-26 10:20           ` Peter Lieven [this message]
2017-06-26 11:21         ` Kevin Wolf
2017-06-26 11:37           ` Peter Lieven
2017-06-26 10:04     ` Daniel P. Berrange
2017-06-26 10:15       ` Denis V. Lunev
2017-06-26 10:23         ` Peter Lieven
2017-06-26 11:12   ` Daniel P. Berrange
2017-06-26 11:44     ` Richard W.M. Jones
2017-06-26 20:30   ` Denis V. Lunev
2017-06-26 20:54     ` Peter Lieven
2017-06-26 20:56       ` Denis V. Lunev
2017-06-26 21:30     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b498b622-2aa8-3cfc-112d-a8f931d2f08f@kamp.de \
    --to=pl@kamp.de \
    --cc=berrange@redhat.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).