From: Laurent Vivier <laurent@vivier.eu>
To: Helge Deller <deller@gmx.de>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] linux-user: Improve strace output of personality() and sysinfo()
Date: Mon, 30 Jan 2023 09:44:08 +0100 [thread overview]
Message-ID: <b49b0d9e-665f-1a1c-e64b-d5036f68911b@vivier.eu> (raw)
In-Reply-To: <Y9QxskymWJjrKQmT@p100>
Le 27/01/2023 à 21:18, Helge Deller a écrit :
> Make the strace look nicer for those two syscalls.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> --
> v2: use TARGET_ABI_FMT_lx instead of %p in personality output
> as suggested by Philippe Mathieu-Daudé and Laurent Vivier
>
>
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index f9254725a1..703c0f1608 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -1043,7 +1043,8 @@
> { TARGET_NR_perfctr, "perfctr" , NULL, NULL, NULL },
> #endif
> #ifdef TARGET_NR_personality
> -{ TARGET_NR_personality, "personality" , NULL, NULL, NULL },
> +{ TARGET_NR_personality, "personality" , "%s(0x"TARGET_ABI_FMT_lx")", NULL,
> + print_syscall_ret_addr },
> #endif
> #ifdef TARGET_NR_pipe
> { TARGET_NR_pipe, "pipe" , NULL, NULL, NULL },
> @@ -1502,7 +1503,7 @@
> { TARGET_NR_sysfs, "sysfs" , NULL, NULL, NULL },
> #endif
> #ifdef TARGET_NR_sysinfo
> -{ TARGET_NR_sysinfo, "sysinfo" , NULL, NULL, NULL },
> +{ TARGET_NR_sysinfo, "sysinfo" , "%s(%p)", NULL, NULL },
> #endif
> #ifdef TARGET_NR_sys_kexec_load
> { TARGET_NR_sys_kexec_load, "sys_kexec_load" , NULL, NULL, NULL },
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2023-01-30 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 10:01 [PATCH] linux-user: Improve strace output of personality() and sysinfo() Helge Deller
2022-12-23 10:50 ` Philippe Mathieu-Daudé
2022-12-23 10:53 ` Helge Deller
2022-12-23 11:01 ` Philippe Mathieu-Daudé
2022-12-23 12:27 ` Helge Deller
2023-01-26 16:25 ` Laurent Vivier
2023-01-27 20:18 ` [PATCH v2] " Helge Deller
2023-01-27 22:53 ` Richard Henderson
2023-01-30 8:44 ` Laurent Vivier [this message]
2023-01-30 8:52 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b49b0d9e-665f-1a1c-e64b-d5036f68911b@vivier.eu \
--to=laurent@vivier.eu \
--cc=deller@gmx.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).