From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Sven Schnelle <svens@stackframe.org>,
Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, deller@gmx.de,
BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [PATCH v3] hw/scsi/lsi53c895a: add timer to scripts processing
Date: Fri, 8 Mar 2024 09:14:39 +0100 [thread overview]
Message-ID: <b4ad4e19-6bb0-4eb2-93ca-4a746afa3816@linaro.org> (raw)
In-Reply-To: <20240304163727.2320861-1-svens@stackframe.org>
On 4/3/24 17:37, Sven Schnelle wrote:
> HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location
> under certain circumstances. As the SCSI controller and CPU are not
> running at the same time this loop will never finish. After some
> time, the check loop interrupts with a unexpected device disconnect.
> This works, but is slow because the kernel resets the scsi controller.
> Instead of signaling UDC, start a timer and exit the loop. Until the
> timer fires, the CPU can process instructions which might change the
> memory location.
>
> The limit of instructions is also reduced because scripts running on
> the SCSI processor are usually very short. This keeps the time until
> the loop is exited short.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/scsi/lsi53c895a.c | 43 +++++++++++++++++++++++++++++++++----------
> hw/scsi/trace-events | 2 ++
> 2 files changed, 35 insertions(+), 10 deletions(-)
I suppose Paolo is going to take this patch, otherwise I can
queue it via hw-misc tree.
next prev parent reply other threads:[~2024-03-08 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:37 [PATCH v3] hw/scsi/lsi53c895a: add timer to scripts processing Sven Schnelle
2024-03-08 8:14 ` Philippe Mathieu-Daudé [this message]
2024-03-10 15:35 ` Michael Tokarev
2024-03-10 18:59 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4ad4e19-6bb0-4eb2-93ca-4a746afa3816@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=deller@gmx.de \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).