From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] qemu-img: fix info --backing-chain --image-opts
Date: Thu, 5 Dec 2019 10:35:55 -0600 [thread overview]
Message-ID: <b4b24003-4327-2bbf-dbc8-cd911d730043@redhat.com> (raw)
In-Reply-To: <20191205134646.445427-1-stefanha@redhat.com>
On 12/5/19 7:46 AM, Stefan Hajnoczi wrote:
> Only apply --image-opts to the topmost image when listing an entire
> backing chain. It is incorrect to treat backing filenames as image
> options. Assuming we have the backing chain t.IMGFMT.base <-
> t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows:
>
> $ qemu-img info --backing-chain --image-opts \
> driver=qcow2,file.driver=file,file.filename=t.IMGFMT
> qemu-img: Could not open 'TEST_DIR/t.IMGFMT.mid': Cannot find device=TEST_DIR/t.IMGFMT.mid nor node_name=TEST_DIR/t.IMGFMT.mid
Cute failure. Yes, the fix seems right.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-img.c | 3 ++
> tests/qemu-iotests/279 | 56 ++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/279.out | 35 ++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 95 insertions(+)
> create mode 100755 tests/qemu-iotests/279
> create mode 100644 tests/qemu-iotests/279.out
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-12-05 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 13:46 [PATCH] qemu-img: fix info --backing-chain --image-opts Stefan Hajnoczi
2019-12-05 16:35 ` Eric Blake [this message]
2019-12-06 10:42 ` Alberto Garcia
2019-12-10 15:02 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4b24003-4327-2bbf-dbc8-cd911d730043@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).