From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
qemu-devel@nongnu.org, Michael Tsirkin <mst@redhat.com>,
Fan Ni <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
Dave Jiang <dave.jiang@intel.com>,
linuxarm@huawei.com
Subject: Re: [PATCH 3/4] hw/cxl/cxl_device: Replace magic number in CXLError definition
Date: Mon, 4 Sep 2023 15:46:15 +0200 [thread overview]
Message-ID: <b4c9daf6-e262-18b7-b100-5e904fd0758b@linaro.org> (raw)
In-Reply-To: <20230904132806.6094-4-Jonathan.Cameron@huawei.com>
On 4/9/23 15:28, Jonathan Cameron wrote:
> From: Fan Ni <fan.ni@samsung.com>
>
> Replace the magic number 32 with CXL_RAS_ERR_HEADER_NUM for better code
> readability and maintainability.
Thanks :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
> Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> include/hw/cxl/cxl_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2023-09-04 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 13:28 [PATCH 0/4] hw/cxl: Minor CXL emulation fixes and cleanup Jonathan Cameron via
2023-09-04 13:28 ` [PATCH 1/4] hw/cxl: Fix CFMW config memory leak Jonathan Cameron via
2023-09-12 21:22 ` Fan Ni
2023-09-13 13:59 ` Michael Tokarev
2023-09-04 13:28 ` [PATCH 2/4] hw/pci-bridge/cxl_upstream: Fix bandwidth entry base unit for SSLBIS Jonathan Cameron via
2023-09-04 13:45 ` Philippe Mathieu-Daudé
2023-09-12 21:23 ` Fan Ni
2023-09-22 20:08 ` Michael Tokarev
2023-09-22 20:59 ` Dave Jiang
2023-09-04 13:28 ` [PATCH 3/4] hw/cxl/cxl_device: Replace magic number in CXLError definition Jonathan Cameron via
2023-09-04 13:46 ` Philippe Mathieu-Daudé [this message]
2023-09-04 13:28 ` [PATCH 4/4] docs/cxl: Change to lowercase as others Jonathan Cameron via
2023-09-04 13:46 ` Philippe Mathieu-Daudé
2023-09-12 21:26 ` Fan Ni
2023-09-13 6:38 ` [PATCH 0/4] hw/cxl: Minor CXL emulation fixes and cleanup Philippe Mathieu-Daudé
2023-09-13 14:00 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c9daf6-e262-18b7-b100-5e904fd0758b@linaro.org \
--to=philmd@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dave.jiang@intel.com \
--cc=fan.ni@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).