From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bta3Y-0007RT-Iy for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bta3T-0006GC-Lh for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:51:47 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33007 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bta3T-0006Dj-GA for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:51:43 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9ACmVw3083554 for ; Mon, 10 Oct 2016 08:51:40 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2606scceru-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 10 Oct 2016 08:51:40 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Oct 2016 13:51:38 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 742662190056 for ; Mon, 10 Oct 2016 13:50:53 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9ACpZNZ25493522 for ; Mon, 10 Oct 2016 12:51:35 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9ACpYdC024913 for ; Mon, 10 Oct 2016 06:51:35 -0600 References: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com> <1476100224-19760-2-git-send-email-imbrenda@linux.vnet.ibm.com> From: Christian Borntraeger Date: Mon, 10 Oct 2016 14:51:34 +0200 MIME-Version: 1.0 In-Reply-To: <1476100224-19760-2-git-send-email-imbrenda@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini Cc: Claudio Imbrenda , qemu-devel@nongnu.org On 10/10/2016 01:50 PM, Claudio Imbrenda wrote: > Commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 introduced a bug that > causes single-step in the gdbstub to not work, at least in kvm. CPUs > that are supposed to single-step will instead run normally. > > This small patch fixes the problem. (tested on s390x) > > Signed-off-by: Claudio Imbrenda > --- > kvm-all.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kvm-all.c b/kvm-all.c > index efb5fe3..46b8dcd 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -2237,6 +2237,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap) > data.dbg.control |= KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTEP; > } > kvm_arch_update_guest_debug(cpu, &data.dbg); > + data.cpu = cpu; > > run_on_cpu(cpu, kvm_invoke_set_guest_debug, &data); > return data.err; > Adding Alex and Paolo to cc.