* [PATCH] fuzz: fix the pro100 generic-fuzzer config
@ 2021-02-21 0:47 Alexander Bulekov
2021-02-21 8:47 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Bulekov @ 2021-02-21 0:47 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini
The device-type names for the pro100 network cards, are i8255.. We were
matching "eepro", which catches the PCI PIO/MMIO regions for those
devices, however misses the actual PCI device, which we use to map the
BARs, before fuzzing. Fix that
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
index 5d599765c4..2454c627ff 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = {
.name = "i82550",
.args = "-machine q35 -nodefaults "
"-device i82550,netdev=net0 -netdev user,id=net0",
- .objects = "eepro*"
+ .objects = "i8255*"
},{
.name = "sdhci-v3",
.args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fuzz: fix the pro100 generic-fuzzer config
2021-02-21 0:47 [PATCH] fuzz: fix the pro100 generic-fuzzer config Alexander Bulekov
@ 2021-02-21 8:47 ` Philippe Mathieu-Daudé
2021-02-22 16:08 ` Alexander Bulekov
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-21 8:47 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, Bandan Das,
Stefan Hajnoczi
On 2/21/21 1:47 AM, Alexander Bulekov wrote:
> The device-type names for the pro100 network cards, are i8255.. We were
> matching "eepro", which catches the PCI PIO/MMIO regions for those
> devices, however misses the actual PCI device, which we use to map the
> BARs, before fuzzing. Fix that
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 5d599765c4..2454c627ff 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = {
> .name = "i82550",
> .args = "-machine q35 -nodefaults "
> "-device i82550,netdev=net0 -netdev user,id=net0",
> - .objects = "eepro*"
> + .objects = "i8255*"
What about i82562 & i82801?
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fuzz: fix the pro100 generic-fuzzer config
2021-02-21 8:47 ` Philippe Mathieu-Daudé
@ 2021-02-22 16:08 ` Alexander Bulekov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Bulekov @ 2021-02-22 16:08 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Thomas Huth, qemu-devel, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini
On 210221 0947, Philippe Mathieu-Daudé wrote:
> On 2/21/21 1:47 AM, Alexander Bulekov wrote:
> > The device-type names for the pro100 network cards, are i8255.. We were
> > matching "eepro", which catches the PCI PIO/MMIO regions for those
> > devices, however misses the actual PCI device, which we use to map the
> > BARs, before fuzzing. Fix that
> >
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> > tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> > index 5d599765c4..2454c627ff 100644
> > --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> > +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> > @@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = {
> > .name = "i82550",
> > .args = "-machine q35 -nodefaults "
> > "-device i82550,netdev=net0 -netdev user,id=net0",
> > - .objects = "eepro*"
> > + .objects = "i8255*"
>
> What about i82562 & i82801?
True. If we start fuzzing those, we will need to adjust the config.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-22 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-21 0:47 [PATCH] fuzz: fix the pro100 generic-fuzzer config Alexander Bulekov
2021-02-21 8:47 ` Philippe Mathieu-Daudé
2021-02-22 16:08 ` Alexander Bulekov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).