From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90A7CC4345F for ; Wed, 1 May 2024 19:21:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2FVT-0005yJ-O9; Wed, 01 May 2024 15:20:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2FVJ-0005vC-0u for qemu-devel@nongnu.org; Wed, 01 May 2024 15:20:34 -0400 Received: from madrid.collaboradmins.com ([46.235.227.194]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2FVG-0004HF-DW for qemu-devel@nongnu.org; Wed, 01 May 2024 15:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1714591228; bh=BKh3g0NzH2er81TfqxIQvit8BalG1L5k6rkntlT6i2E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QFxWqaZ1m2XO9w7YVNhAK4+dcjacH3ITzhUrWqZttmkuLOHgn4HD+wc0QJ2qYQ8TG D+ag394L2pmQUlvlUzXPDPXqq9mLuABrIdT3E0El2Spxnkzm3kmkDWUKJ8z2GIOgVa 8BxxO0nwHkt8yRbgIc+G1i55onUDCASpTDNRJmpo00gVhcJGMRUz7ZyOLgbzWZB6dH sCH5zIXryRlHUO/RG2zNTBB9UfcjoqGPoRdL4kWKeRmtZJ2Ancw+kUhJR1631FPkQK qXZKASNWGh3C+jJ6v0JneXRjMui5GtQiaryfh4qOs6oUnzrlMEe+foPuFfKii4G1Fc w/3hndUqqiGag== Received: from [100.109.49.129] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 1C2693780629; Wed, 1 May 2024 19:20:25 +0000 (UTC) Message-ID: Date: Wed, 1 May 2024 22:20:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 08/11] virtio-gpu: Handle resource blob commands To: Akihiko Odaki , Huang Rui , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony PERARD , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Gert Wollny , =?UTF-8?Q?Alex_Benn=C3=A9e?= Cc: qemu-devel@nongnu.org, Gurchetan Singh , ernunes@redhat.com, Alyssa Ross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian , Yiwei Zhang References: <20240418190040.1110210-1-dmitry.osipenko@collabora.com> <20240418190040.1110210-9-dmitry.osipenko@collabora.com> <2c5a0b2e-58ef-4766-baea-5df98fa6fc2f@daynix.com> <51b45c53-b7d3-4f3c-984c-44a94e6cf5af@collabora.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.235.227.194; envelope-from=dmitry.osipenko@collabora.com; helo=madrid.collaboradmins.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/27/24 08:52, Akihiko Odaki wrote: > On 2024/04/24 19:30, Dmitry Osipenko wrote: >> On 4/19/24 12:18, Akihiko Odaki wrote: >>>> @@ -61,6 +61,10 @@ struct virtio_gpu_simple_resource { >>>>        int dmabuf_fd; >>>>        uint8_t *remapped; >>>>    +    MemoryRegion *mr; >>>> +    bool async_unmap_completed; >>>> +    bool async_unmap_in_progress; >>>> + >>> >>> Don't add fields to virtio_gpu_simple_resource but instead create a >>> struct that embeds virtio_gpu_simple_resource in virtio-gpu-virgl.c. >> >> Please give a justification. I'd rather rename >> virtio_gpu_simple_resource s/_simple//. Simple resource already supports >> blob and the added fields are directly related to the blob. Don't see >> why another struct is needed. >> > > Because mapping is only implemented in virtio-gpu-gl while blob itself > is implemented also in virtio-gpu. Rutubaga maps blobs and it should do unmapping blobs asynchronously as well, AFAICT. -- Best regards, Dmitry