Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

[Thomas Huth <thuth@redhat.com>]

On 2019-01-08 20:12, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> This patch series got stuck.
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Fam Zheng <famz@redhat.com> writes:
>>>
>>>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>>>> Jeff Cody <jcody@redhat.com> writes:
>>>>>
>>>>>> I'll not be involved in day-to-day qemu development.  Remove
>>>>>> myself as maintainer from the remainder of the network block drivers
>>>>>> (and vhdx), and revert them to the general block layer maintainership.
>>>>>>
>>>>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>>>>> ---
>>>>>>  MAINTAINERS | 14 --------------
>>>>>>  1 file changed, 14 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index e93f79672f..6ef6932628 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>>>>>  
>>>>>>  RBD
>>>>>>  M: Josh Durgin <jdurgin@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/rbd.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  Sheepdog
>>>>>>  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>>>>>  M: Liu Yuan <namei.unix@gmail.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  L: sheepdog@lists.wpkg.org
>>>>>>  S: Supported
>>>>>>  F: block/sheepdog.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  VHDX
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/vhdx*
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Does "S: Supported" make sense without an M:?
>>>>>
>>>>>>  
>>>>>>  VDI
>>>>>>  M: Stefan Weil <sw@weilnetz.de>
>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>>>>>  T: git git://repo.or.cz/qemu/ericb.git nbd
>>>>>>  
>>>>>>  NFS
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  M: Peter Lieven <pl@kamp.de>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Maintained
>>>>>>  F: block/nfs.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  SSH
>>>>>>  M: Richard W.M. Jones <rjones@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/ssh.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  CURL
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/curl.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>>  GLUSTER
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/gluster.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>>  Null Block Driver
>>>>>>  M: Fam Zheng <famz@redhat.com>
>>>>>
>>>>
>>>> Block drivers without an M: naturally fall under the overall maintainership of
>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>>>> degraded to Maintained, though.
>>>
>>> Yes, get_maintainer.pl combines all applicable sections.  Human readers
>>> are left to wonder, unless they know to look for other matches.
>>>
>>> Do we want to have a dedicated network block driver submaintainer again,
>>> if we can find one?
>>>
>>> Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
>>> you're maintaining VMDK, could you cover VHDX as well?
>>
>> Fam can't.
>>
>> I can see two sane options for the three sections that lose their sole
>> maintainer (VHDX, CURL, GLUSTER):
>>
>> * Downgrade to S: Orphan
>>
>>   This reflects the fact that we'd like to have dedicated maintainers
>>   for them.  It camouflages the fact that the "Block layer core"
>>   maintainers pick up the slack.
>>
>> * Delete
>>
>>   The opposite.
>>
>> Kevin, Max, please pick your poison, or suggest one you find tastier.
> 
> Orphan is probably by far closer to the truth than Supported. But I
> think what we really do is Odd Fixes. Not sure if that's a status that
> works in any meaningful way without having a maintainer for the specific
> thing assigned?

IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line,
like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a
"L:" line anymore, it should be marked with "Orphan" instead.

 Thomas