From: Gavin Shan <gshan@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm/kvm64.c: Remove unused include
Date: Wed, 27 Sep 2023 17:19:52 +1000 [thread overview]
Message-ID: <b52f83ec-e8ee-88ad-15d6-78dc7f8a6f35@redhat.com> (raw)
In-Reply-To: <20230925110429.3917202-1-peter.maydell@linaro.org>
On 9/25/23 21:04, Peter Maydell wrote:
> The include of hw/arm/virt.h in kvm64.c is unnecessary and also a
> layering violation since the generic KVM code shouldn't need to know
> anything about board-specifics. The include line is an accidental
> leftover from commit 15613357ba53a4763, where we cleaned up the code
> to not depend on virt board internals but forgot to also remove the
> now-redundant include line.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/kvm64.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
> diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
> index 5e95c496bb9..3ea9f1d6743 100644
> --- a/target/arm/kvm64.c
> +++ b/target/arm/kvm64.c
> @@ -30,7 +30,6 @@
> #include "internals.h"
> #include "hw/acpi/acpi.h"
> #include "hw/acpi/ghes.h"
> -#include "hw/arm/virt.h"
>
> static bool have_guest_debug;
>
next prev parent reply other threads:[~2023-09-27 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 11:04 [PATCH] target/arm/kvm64.c: Remove unused include Peter Maydell
2023-09-27 7:19 ` Gavin Shan [this message]
2023-10-02 6:53 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52f83ec-e8ee-88ad-15d6-78dc7f8a6f35@redhat.com \
--to=gshan@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).