* [PATCH] target/arm/kvm64.c: Remove unused include
@ 2023-09-25 11:04 Peter Maydell
2023-09-27 7:19 ` Gavin Shan
2023-10-02 6:53 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2023-09-25 11:04 UTC (permalink / raw)
To: qemu-arm, qemu-devel
The include of hw/arm/virt.h in kvm64.c is unnecessary and also a
layering violation since the generic KVM code shouldn't need to know
anything about board-specifics. The include line is an accidental
leftover from commit 15613357ba53a4763, where we cleaned up the code
to not depend on virt board internals but forgot to also remove the
now-redundant include line.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/kvm64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 5e95c496bb9..3ea9f1d6743 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -30,7 +30,6 @@
#include "internals.h"
#include "hw/acpi/acpi.h"
#include "hw/acpi/ghes.h"
-#include "hw/arm/virt.h"
static bool have_guest_debug;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm/kvm64.c: Remove unused include
2023-09-25 11:04 [PATCH] target/arm/kvm64.c: Remove unused include Peter Maydell
@ 2023-09-27 7:19 ` Gavin Shan
2023-10-02 6:53 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Gavin Shan @ 2023-09-27 7:19 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel
On 9/25/23 21:04, Peter Maydell wrote:
> The include of hw/arm/virt.h in kvm64.c is unnecessary and also a
> layering violation since the generic KVM code shouldn't need to know
> anything about board-specifics. The include line is an accidental
> leftover from commit 15613357ba53a4763, where we cleaned up the code
> to not depend on virt board internals but forgot to also remove the
> now-redundant include line.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/kvm64.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
> diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
> index 5e95c496bb9..3ea9f1d6743 100644
> --- a/target/arm/kvm64.c
> +++ b/target/arm/kvm64.c
> @@ -30,7 +30,6 @@
> #include "internals.h"
> #include "hw/acpi/acpi.h"
> #include "hw/acpi/ghes.h"
> -#include "hw/arm/virt.h"
>
> static bool have_guest_debug;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm/kvm64.c: Remove unused include
2023-09-25 11:04 [PATCH] target/arm/kvm64.c: Remove unused include Peter Maydell
2023-09-27 7:19 ` Gavin Shan
@ 2023-10-02 6:53 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-02 6:53 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel
On 25/9/23 13:04, Peter Maydell wrote:
> The include of hw/arm/virt.h in kvm64.c is unnecessary and also a
> layering violation since the generic KVM code shouldn't need to know
> anything about board-specifics. The include line is an accidental
> leftover from commit 15613357ba53a4763, where we cleaned up the code
> to not depend on virt board internals but forgot to also remove the
> now-redundant include line.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/kvm64.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-02 6:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 11:04 [PATCH] target/arm/kvm64.c: Remove unused include Peter Maydell
2023-09-27 7:19 ` Gavin Shan
2023-10-02 6:53 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).