From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/6] usb-storage: switch trace events
Date: Thu, 5 Nov 2020 15:26:30 +0100 [thread overview]
Message-ID: <b533058d-3f6c-9200-6ea1-701688953149@redhat.com> (raw)
In-Reply-To: <20201105134112.25119-2-kraxel@redhat.com>
On 11/5/20 2:41 PM, Gerd Hoffmann wrote:
> Replace most DPRINTF macros with trace events.
> Drop some DPRINTF macros.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/dev-storage.c | 42 +++++++++++++++++-------------------------
> hw/usb/trace-events | 12 ++++++++++++
> 2 files changed, 29 insertions(+), 25 deletions(-)
...
> diff --git a/hw/usb/trace-events b/hw/usb/trace-events
> index a3292d46248f..38e05fc7f4db 100644
> --- a/hw/usb/trace-events
> +++ b/hw/usb/trace-events
> @@ -252,6 +252,18 @@ usb_hub_attach(int addr, int nr) "dev %d, port %d"
> usb_hub_detach(int addr, int nr) "dev %d, port %d"
> usb_hub_status_report(int addr, int status) "dev %d, status 0x%x"
>
> +# dev-storage.c
> +usb_msd_reset(void) ""
> +usb_msd_maxlun(unsigned maxlun) "%d"
> +usb_msd_send_status(unsigned status, unsigned tag, size_t size) "status %d, tag 0x%x, len %zd"
> +usb_msd_data_in(unsigned packet, unsigned remaining, unsigned total) "%d/%d (scsi %d)"
> +usb_msd_data_out(unsigned packet, unsigned remaining) "%d/%d"
> +usb_msd_packet_async(void) ""
> +usb_msd_packet_complete(void) ""
> +usb_msd_cmd_submit(unsigned lun, unsigned tag, unsigned flags, unsigned len, unsigned data_len) "lun %u, tag 0x%x, flags 0x%08x, len %d, data-len %d"
> +usb_msd_cmd_complete(unsigned status, unsigned tag) "status %d, tag 0x%x"
Using '%u' format for unsigned type:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-11-05 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 13:41 [PATCH 0/6] usb: fix some guest-triggerable asserts Gerd Hoffmann
2020-11-05 13:41 ` [PATCH 1/6] usb-storage: switch trace events Gerd Hoffmann
2020-11-05 14:26 ` Philippe Mathieu-Daudé [this message]
2020-11-05 13:41 ` [PATCH 2/6] usb-storage: add commandlog property Gerd Hoffmann
2020-11-05 14:27 ` Philippe Mathieu-Daudé
2020-11-05 13:41 ` [PATCH 3/6] usb-storage: use bool for removable property Gerd Hoffmann
2020-11-05 14:27 ` Philippe Mathieu-Daudé
2020-11-05 13:41 ` [PATCH 4/6] usb-storage: fill csw on cancel Gerd Hoffmann
2020-11-05 13:41 ` [PATCH 5/6] xhci: fix guest triggerable assert Gerd Hoffmann
2020-11-05 14:28 ` Philippe Mathieu-Daudé
2020-11-05 13:41 ` [PATCH 6/6] xhci: move sanity checks Gerd Hoffmann
2020-11-05 14:30 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b533058d-3f6c-9200-6ea1-701688953149@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).