From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56487C4741F for ; Wed, 30 Sep 2020 16:11:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20FC206F7 for ; Wed, 30 Sep 2020 16:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IqfMmTtX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20FC206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNehR-0003Cp-O7 for qemu-devel@archiver.kernel.org; Wed, 30 Sep 2020 12:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNegP-0002JV-Gi for qemu-devel@nongnu.org; Wed, 30 Sep 2020 12:10:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kNegM-00037i-A7 for qemu-devel@nongnu.org; Wed, 30 Sep 2020 12:10:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601482214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=texujQ5iGf6D5hUqlZOFLb1WfRmE8HMmauyTS/DUFdU=; b=IqfMmTtXnuHxNO05UJzhAH75qnYVUCWFkxfLwtKRieHGfv2aG9HHjIx2+5CTfaAarmYuCr Z05Kd4GUZ2nuP84nh7PODPDH9nHJHKlS9B5lDrz/57wpHrN/z2u/LyAf3rSIWulAwX5TD1 J6G9JOJbbnSIdcDzO6BVIN56UFlz47A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-XLK7iyjrONy46Acm8JIFzA-1; Wed, 30 Sep 2020 12:10:12 -0400 X-MC-Unique: XLK7iyjrONy46Acm8JIFzA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A907810BBEC9; Wed, 30 Sep 2020 16:10:09 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-148.ams2.redhat.com [10.36.112.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9089D10016DA; Wed, 30 Sep 2020 16:10:08 +0000 (UTC) Subject: Re: [Qemu-devel] [PULL 04/28] hw/arm: Express dependencies of the highbank machines with Kconfig To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell , qemu-devel@nongnu.org References: <20190505135714.11277-1-thuth@redhat.com> <20190505135714.11277-5-thuth@redhat.com> From: Thomas Huth Message-ID: Date: Wed, 30 Sep 2020 18:10:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/30 00:26:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.469, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 30/09/2020 17.38, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 5/5/19 3:56 PM, Thomas Huth wrote: >> Add Kconfig dependencies for the highbank machine (and the midway >> machine). >> This patch is slightly based on earlier work by Ákos Kovács (i.e. >> his "hw/arm/Kconfig: Add ARM Kconfig" patch). >> >> Reviewed-by: Philippe Mathieu-Daudé >> Tested-by: Philippe Mathieu-Daudé >> Signed-off-by: Thomas Huth >> --- >> default-configs/arm-softmmu.mak | 9 +-------- >> hw/arm/Kconfig | 11 +++++++++++ >> 2 files changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak >> index 2a11e76cc7..50a4be3cad 100644 >> --- a/default-configs/arm-softmmu.mak >> +++ b/default-configs/arm-softmmu.mak >> @@ -8,6 +8,7 @@ CONFIG_PCI_DEVICES=y >> CONFIG_PCI_TESTDEV=y >> >> CONFIG_EXYNOS4=y >> +CONFIG_HIGHBANK=y >> >> CONFIG_VGA=y >> CONFIG_NAND=y >> @@ -45,24 +46,17 @@ CONFIG_PLATFORM_BUS=y >> CONFIG_VIRTIO_MMIO=y >> >> CONFIG_ARM11MPCORE=y >> -CONFIG_A15MPCORE=y >> >> CONFIG_NETDUINO2=y >> >> -CONFIG_ARM_TIMER=y >> -CONFIG_PL011=y >> -CONFIG_PL022=y >> -CONFIG_PL031=y >> CONFIG_PL041=y >> CONFIG_PL050=y >> -CONFIG_PL061=y >> CONFIG_PL080=y >> CONFIG_PL110=y >> CONFIG_PL181=y >> CONFIG_PL190=y >> CONFIG_PL330=y >> CONFIG_CADENCE=y >> -CONFIG_XGMAC=y >> CONFIG_PXA2XX=y >> CONFIG_BITBANG_I2C=y >> CONFIG_FRAMEBUFFER=y >> @@ -150,7 +144,6 @@ CONFIG_XILINX_AXI=y >> CONFIG_PCI_EXPRESS_DESIGNWARE=y >> >> CONFIG_STRONGARM=y >> -CONFIG_HIGHBANK=y >> CONFIG_MUSICPAL=y >> >> # for realview and versatilepb >> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig >> index acd07b2add..0ba377ac18 100644 >> --- a/hw/arm/Kconfig >> +++ b/hw/arm/Kconfig >> @@ -18,6 +18,17 @@ config EXYNOS4 >> >> config HIGHBANK >> bool >> + select A9MPCORE >> + select A15MPCORE >> + select AHCI >> + select ARM_TIMER # sp804 >> + select ARM_V7M > > Hmm I missed that... This machine doesn't use a v7M core, right? I think you're right: The machines seem to use A9 and A15 ... so I guess this was a copy-n-paste bug ... could you send a patch to clean it up, please? Thomas