From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Stefan Weil" <sw@weilnetz.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH v3 10/20] monitor: remove redundant error_[v]printf_unless_qmp
Date: Thu, 11 Sep 2025 08:50:49 +0000 [thread overview]
Message-ID: <b5681050-2e15-438d-88fa-cd9e612be2c8@linaro.org> (raw)
In-Reply-To: <20250910180357.320297-11-berrange@redhat.com>
On 9/10/25 18:03, Daniel P. Berrangé wrote:
> These functions only had one caller which was easily converted to
> the normal error_printf() function. Remove them as they don't add
> sufficient value.
>
> Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
> ---
> include/monitor/monitor.h | 3 ---
> monitor/monitor.c | 24 ------------------------
> stubs/error-printf.c | 5 -----
> 3 files changed, 32 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-09-11 8:51 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 18:03 [PATCH v3 00/20] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 01/20] include: define constant for early constructor priority Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 02/20] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-09-17 14:07 ` Markus Armbruster
2025-09-17 15:31 ` Daniel P. Berrangé
2025-09-18 6:30 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 03/20] system: unconditionally enable thread naming Daniel P. Berrangé
2025-09-11 12:18 ` Ján Tomko
2025-09-19 8:20 ` Markus Armbruster
2025-09-19 13:32 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 04/20] util: expose qemu_thread_set_name Daniel P. Berrangé
2025-09-19 8:39 ` Markus Armbruster
2025-09-24 8:37 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 05/20] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2025-09-11 13:21 ` Christian Schoenebeck
2025-09-12 14:58 ` Daniel P. Berrangé
2025-09-19 8:46 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 06/20] util: set the name for the 'main' thread Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 07/20] util: add API to fetch the current thread name Daniel P. Berrangé
2025-09-19 8:59 ` Markus Armbruster
2025-09-19 9:05 ` Daniel P. Berrangé
2025-09-19 11:35 ` Markus Armbruster
2025-09-23 12:12 ` Markus Armbruster
2025-09-24 8:55 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 08/20] log: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2025-09-10 23:20 ` Dr. David Alan Gilbert
2025-09-11 8:49 ` Richard Henderson
2025-09-17 14:11 ` Markus Armbruster
2025-09-17 15:33 ` Daniel P. Berrangé
2025-09-23 12:46 ` Philippe Mathieu-Daudé
2025-09-23 14:28 ` Markus Armbruster
2025-09-23 14:55 ` Daniel P. Berrangé
2025-09-24 7:06 ` Markus Armbruster
2025-09-24 7:12 ` Daniel P. Berrangé
2025-09-24 9:20 ` Daniel P. Berrangé
2025-09-24 12:34 ` Markus Armbruster
2025-09-24 13:30 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 09/20] ui/vnc: remove use of error_printf_unless_qmp() Daniel P. Berrangé
2025-09-11 0:08 ` Dr. David Alan Gilbert
2025-09-11 8:51 ` Richard Henderson
2025-09-11 17:54 ` Richard Henderson
2025-09-12 15:11 ` Daniel P. Berrangé
2025-09-19 11:42 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 10/20] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2025-09-11 8:50 ` Richard Henderson [this message]
2025-09-19 11:42 ` Markus Armbruster
2025-09-23 12:48 ` Philippe Mathieu-Daudé
2025-09-10 18:03 ` [PATCH v3 11/20] monitor: move error_vprintf() back to error-report.c Daniel P. Berrangé
2025-09-11 8:55 ` Richard Henderson
2025-09-19 12:27 ` Markus Armbruster
2025-09-19 13:43 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 12/20] monitor: introduce monitor_cur_hmp() function Daniel P. Berrangé
2025-09-11 17:52 ` Richard Henderson
2025-09-19 12:43 ` Markus Armbruster
2025-09-19 13:29 ` Daniel P. Berrangé
2025-09-20 7:06 ` Markus Armbruster
2025-09-20 11:54 ` Dr. David Alan Gilbert
2025-09-22 8:38 ` Markus Armbruster
2025-09-24 16:09 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 13/20] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2025-09-22 8:43 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 14/20] util: fix interleaving of error & trace output Daniel P. Berrangé
2025-09-11 18:01 ` Richard Henderson
2025-09-11 18:05 ` Richard Henderson
2025-09-12 16:30 ` Daniel P. Berrangé
2025-09-22 12:16 ` Markus Armbruster
2025-09-10 18:03 ` [PATCH v3 15/20] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-09-11 18:02 ` Richard Henderson
2025-09-10 18:03 ` [PATCH v3 16/20] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-09-11 18:04 ` Richard Henderson
2025-09-10 18:03 ` [PATCH v3 17/20] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-09-11 18:06 ` Richard Henderson
2025-09-11 20:27 ` Dr. David Alan Gilbert
2025-09-12 8:34 ` Daniel P. Berrangé
2025-09-12 11:18 ` Dr. David Alan Gilbert
2025-09-10 18:03 ` [PATCH v3 18/20] util: add support for formatting a program " Daniel P. Berrangé
2025-09-11 18:07 ` Richard Henderson
2025-09-11 18:08 ` Richard Henderson
2025-09-12 16:33 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 19/20] util: add support for formatting thread info " Daniel P. Berrangé
2025-09-11 18:11 ` Richard Henderson
2025-09-12 8:36 ` Daniel P. Berrangé
2025-09-10 18:03 ` [PATCH v3 20/20] util: add brackets around guest name in message context Daniel P. Berrangé
2025-09-11 18:12 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5681050-2e15-438d-88fa-cd9e612be2c8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=hreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).