[Qemu-devel] Problem in pcie_pci_bridge_realize()

[Qemu-devel] Problem in pcie_pci_bridge_realize()

[Thomas Huth]

 Hi,

QEMU currently aborts with an assertion when plugging of the
pcie-pci-bridge fails, e.g.:

$ mips64el-softmmu/qemu-system-mips64el -M malta -nographic -S \
                -device pcie-pci-bridge -bios pc-bios/bios.bin 
qemu-system-mips64el: memory.c:1699: memory_region_finalize:
 Assertion `!mr->container' failed.
Aborted (core dumped)

The backtrace points to the pcie_pci_bridge_realize() function:

#0  0x00007ffff150f1f7 in raise () at /lib64/libc.so.6
#1  0x00007ffff15108e8 in abort () at /lib64/libc.so.6
#2  0x00007ffff1508266 in __assert_fail_base () at /lib64/libc.so.6
#3  0x00007ffff1508312 in  () at /lib64/libc.so.6
#4  0x00005555557cedaf in memory_region_finalize (obj=<optimized out>)
    at /home/thuth/devel/qemu/memory.c:1699
#5  0x0000555555a49852 in object_unref (type=<optimized out>, obj=0x555556e68580)
    at /home/thuth/devel/qemu/qom/object.c:453
#6  0x0000555555a49852 in object_unref (data=0x555556e68580) at /home/thuth/devel/qemu/qom/object.c:467
#7  0x0000555555a49852 in object_unref (obj=0x555556e68580) at /home/thuth/devel/qemu/qom/object.c:902
#8  0x0000555555a48887 in object_property_del_child (obj=0x555556dc7760, child=child@entry=0x555556e68580, errp=0x0) at /home/thuth/devel/qemu/qom/object.c:427
#9  0x0000555555a490a4 in object_unparent (obj=obj@entry=0x555556e68580)
    at /home/thuth/devel/qemu/qom/object.c:446
#10 0x00005555559906ae in shpc_free (d=d@entry=0x555556dc7760)
    at /home/thuth/devel/qemu/hw/pci/shpc.c:676
#11 0x0000555555987470 in pcie_pci_bridge_realize (d=0x555556dc7760, errp=0x7fffffffd710)
    at /home/thuth/devel/qemu/hw/pci-bridge/pcie_pci_bridge.c:84
#12 0x000055555598ca67 in pci_qdev_realize (qdev=0x555556dc7760, errp=0x7fffffffd7b0)
    at /home/thuth/devel/qemu/hw/pci/pci.c:2024
#13 0x000055555590ee4a in device_set_realized (obj=<optimized out>, value=<optimized out>, errp=0x7fffffffd8e8) at /home/thuth/devel/qemu/hw/core/qdev.c:914

Any clue what might be wrong here?

 Thomas

Re: [Qemu-devel] Problem in pcie_pci_bridge_realize()

[Aleksandr Bezzubikov]

2017-09-27 18:50 GMT+03:00 Thomas Huth <thuth@redhat.com>:
>  Hi,
>
> QEMU currently aborts with an assertion when plugging of the
> pcie-pci-bridge fails, e.g.:
>
> $ mips64el-softmmu/qemu-system-mips64el -M malta -nographic -S \
>                 -device pcie-pci-bridge -bios pc-bios/bios.bin
> qemu-system-mips64el: memory.c:1699: memory_region_finalize:
>  Assertion `!mr->container' failed.
> Aborted (core dumped)
>
> The backtrace points to the pcie_pci_bridge_realize() function:
>
> #0  0x00007ffff150f1f7 in raise () at /lib64/libc.so.6
> #1  0x00007ffff15108e8 in abort () at /lib64/libc.so.6
> #2  0x00007ffff1508266 in __assert_fail_base () at /lib64/libc.so.6
> #3  0x00007ffff1508312 in  () at /lib64/libc.so.6
> #4  0x00005555557cedaf in memory_region_finalize (obj=<optimized out>)
>     at /home/thuth/devel/qemu/memory.c:1699
> #5  0x0000555555a49852 in object_unref (type=<optimized out>, obj=0x555556e68580)
>     at /home/thuth/devel/qemu/qom/object.c:453
> #6  0x0000555555a49852 in object_unref (data=0x555556e68580) at /home/thuth/devel/qemu/qom/object.c:467
> #7  0x0000555555a49852 in object_unref (obj=0x555556e68580) at /home/thuth/devel/qemu/qom/object.c:902
> #8  0x0000555555a48887 in object_property_del_child (obj=0x555556dc7760, child=child@entry=0x555556e68580, errp=0x0) at /home/thuth/devel/qemu/qom/object.c:427
> #9  0x0000555555a490a4 in object_unparent (obj=obj@entry=0x555556e68580)
>     at /home/thuth/devel/qemu/qom/object.c:446
> #10 0x00005555559906ae in shpc_free (d=d@entry=0x555556dc7760)
>     at /home/thuth/devel/qemu/hw/pci/shpc.c:676
> #11 0x0000555555987470 in pcie_pci_bridge_realize (d=0x555556dc7760, errp=0x7fffffffd710)
>     at /home/thuth/devel/qemu/hw/pci-bridge/pcie_pci_bridge.c:84
> #12 0x000055555598ca67 in pci_qdev_realize (qdev=0x555556dc7760, errp=0x7fffffffd7b0)
>     at /home/thuth/devel/qemu/hw/pci/pci.c:2024
> #13 0x000055555590ee4a in device_set_realized (obj=<optimized out>, value=<optimized out>, errp=0x7fffffffd8e8) at /home/thuth/devel/qemu/hw/core/qdev.c:914
>
> Any clue what might be wrong here?
>
>  Thomas

Hi Thomas,
This bug was already reported by Eduardo with ppc64, try this patch
that is intended to fix it

http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg06696.html

-- 
Aleksandr Bezzubikov

Re: [Qemu-devel] Problem in pcie_pci_bridge_realize()

[Thomas Huth]

On 27.09.2017 18:22, Aleksandr Bezzubikov wrote:
> 2017-09-27 18:50 GMT+03:00 Thomas Huth <thuth@redhat.com>:
>>  Hi,
>>
>> QEMU currently aborts with an assertion when plugging of the
>> pcie-pci-bridge fails, e.g.:
>>
>> $ mips64el-softmmu/qemu-system-mips64el -M malta -nographic -S \
>>                 -device pcie-pci-bridge -bios pc-bios/bios.bin
>> qemu-system-mips64el: memory.c:1699: memory_region_finalize:
>>  Assertion `!mr->container' failed.
>> Aborted (core dumped)
[...]
> Hi Thomas,
> This bug was already reported by Eduardo with ppc64, try this patch
> that is intended to fix it
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg06696.html

Thanks, that fixed the issue indeed!

 Thomas