Re: [PATCH 04/23] AArch64 specific CPU for bsd-user

[Richard Henderson <richard.henderson@linaro.org>]

On 6/17/24 11:57, Ajeet Singh wrote:
> From: Stacey Son <sson@FreeBSD.org>
> 
> Function to set and recieve thread-local-storage value
> from tpidr_el0 register
> 
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Ajeet Singh <itachis@FreeBSD.org>
> ---
>   bsd-user/aarch64/target_arch_cpu.c | 34 ++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
>   create mode 100644 bsd-user/aarch64/target_arch_cpu.c
> 
> diff --git a/bsd-user/aarch64/target_arch_cpu.c b/bsd-user/aarch64/target_arch_cpu.c
> new file mode 100644
> index 0000000000..70ef651827
> --- /dev/null
> +++ b/bsd-user/aarch64/target_arch_cpu.c
> @@ -0,0 +1,34 @@
> +/*
> + * ARM AArch64 specific CPU for bsd-user
> + *
> + * Copyright (c) 2015 Stacey Son
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> + */
> +#include "qemu/osdep.h"
> +
> +#include "target_arch.h"
> +
> +/* See cpu_set_user_tls() in arm64/arm64/vm_machdep.c */
> +void target_cpu_set_tls(CPUARMState *env, target_ulong newtls)
> +{
> +
> +    env->cp15.tpidr_el[0] = newtls;

Extra newline.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~