From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A97C4338F for ; Tue, 17 Aug 2021 09:28:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 427D260720 for ; Tue, 17 Aug 2021 09:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 427D260720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFvOO-0004ck-Dd for qemu-devel@archiver.kernel.org; Tue, 17 Aug 2021 05:28:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFvNU-0003Zx-VT for qemu-devel@nongnu.org; Tue, 17 Aug 2021 05:27:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFvNS-0005pE-4W for qemu-devel@nongnu.org; Tue, 17 Aug 2021 05:27:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629192441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ziLibRFq4LmINPnHZ5Vek/4tfRATvMYN2709y185uB4=; b=IQrW2lxI+R300qWioO9EkFau5Bgpg5cAUodNIgMDNHVzwTM1EICLzcRYrwKlHPf9ZHkLya vjlM0Wgz7CgyGVd9M3Iy5bqo1nEugA1h+WIVzEmA//M6jDzsy0u436AZ2fHdNlKBiHP1v+ 4F9gvamRVMHCma87QcYE+0f5CAhoODE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-X8pQyJxlPReUAripeZGEnQ-1; Tue, 17 Aug 2021 05:27:20 -0400 X-MC-Unique: X8pQyJxlPReUAripeZGEnQ-1 Received: by mail-wm1-f69.google.com with SMTP id e12-20020a05600c218cb02902e6bbacdcd1so655759wme.4 for ; Tue, 17 Aug 2021 02:27:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ziLibRFq4LmINPnHZ5Vek/4tfRATvMYN2709y185uB4=; b=peJWnlrWUfnXeBq9WM1nYLusCBI4wB0VkLWhRWw1TRmY+VvIpf1kpo+Il6SLITJlTy ZBxshuHQ5MRe9Kdv0YIKU1Rg0ziQQyk98riXigWDD5C/xjTymYUrRty4zbgVS3+RD+aS cpM0IZP4Wd8rlxWs0/u9sQJnrWvdas6ATXOhAya8qe271YJJqiM8RUJwXeA7/ZIxoEHU LQ4+bDwG9MWMpip9xgFA7gmBAo8BJ8lCcNFpP4kicofNyoIMjbO85JosSYA6vewGHlKj VfSsEJqWJp97XCZjXzxqX5b3Gij7AZEJNhRHQNBIyK4Zy+wOZO9W/yUmMoCF04k2Dqv6 Pguw== X-Gm-Message-State: AOAM531E/VGKMMf3SMAw+WDCCsGHgqZYx5EuABhGREe0Iez1eBjSdbJF M2pwe56X3ZuiyaZQ2XvR3qcTiiYCyjYvx0lB2PyM8eVC9IOg8bmNRYBxpld5uXeyhw2vs5UTmJa 3/HX1nalPjJ8i7dM= X-Received: by 2002:a5d:4691:: with SMTP id u17mr2847187wrq.254.1629192438131; Tue, 17 Aug 2021 02:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy3KbW7rrwuG10oElT1CQ2/Xh4J8Ezjir8osNmrWDfB1gG5noq3GvQwgbK1cMOi6fQXJLqCg== X-Received: by 2002:a5d:4691:: with SMTP id u17mr2847163wrq.254.1629192437872; Tue, 17 Aug 2021 02:27:17 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id o125sm1527044wme.15.2021.08.17.02.27.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 02:27:17 -0700 (PDT) Subject: Re: [PATCH for-6.2 1/2] include/qemu/int128.h: introduce bswap128s To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20210816191316.1163622-1-matheus.ferst@eldorado.org.br> <20210816191316.1163622-2-matheus.ferst@eldorado.org.br> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 17 Aug 2021 11:27:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210816191316.1163622-2-matheus.ferst@eldorado.org.br> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -71 X-Spam_score: -7.2 X-Spam_bar: ------- X-Spam_report: (-7.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.71, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, richard.henderson@linaro.org, groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/16/21 9:13 PM, matheus.ferst@eldorado.org.br wrote: > From: Matheus Ferst > > Introduces bswap128s based on bswap128. Since bswap128 is defined using > int128_* methods available in either CONFIG_INT128 or !CONFIG_INT128 > builds, place both outside of #ifdef CONFIG_INT128. > > Signed-off-by: Matheus Ferst > --- > include/qemu/int128.h | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/include/qemu/int128.h b/include/qemu/int128.h > index 64500385e3..e0d385628c 100644 > --- a/include/qemu/int128.h > +++ b/include/qemu/int128.h > @@ -153,11 +153,6 @@ static inline void int128_subfrom(Int128 *a, Int128 b) > *a -= b; > } > > -static inline Int128 bswap128(Int128 a) > -{ > - return int128_make128(bswap64(int128_gethi(a)), bswap64(int128_getlo(a))); > -} Personally I'd move this one to the other #ifdef side, and implement here with __builtin_bswap128(). > #else /* !CONFIG_INT128 */ > > typedef struct Int128 Int128; > @@ -338,4 +333,15 @@ static inline void int128_subfrom(Int128 *a, Int128 b) > } > +static inline Int128 bswap128(Int128 a) > +{ > + return int128_make128(bswap64(int128_gethi(a)), bswap64(int128_getlo(a))); > +} #endif /* CONFIG_INT128 */ And add this generic one here indeed: > +static inline void bswap128s(Int128 *s) > +{ > + *s = bswap128(*s); > +} > + > #endif /* INT128_H */ >