From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHD26-0005L6-0d for qemu-devel@nongnu.org; Wed, 14 Dec 2016 12:07:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHD20-00008i-To for qemu-devel@nongnu.org; Wed, 14 Dec 2016 12:07:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41092) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHD20-00008S-NT for qemu-devel@nongnu.org; Wed, 14 Dec 2016 12:07:52 -0500 References: <1481567461-2341-1-git-send-email-ehabkost@redhat.com> <87zijyfyq5.fsf@dusky.pond.sub.org> <20161214134841.GG3808@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: Date: Wed, 14 Dec 2016 18:07:48 +0100 MIME-Version: 1.0 In-Reply-To: <20161214134841.GG3808@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Markus Armbruster Cc: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org, Lin Ma On 14/12/2016 14:48, Eduardo Habkost wrote: >> How do you find all abstract TypeInfo in the source? The uninitiated >> might grep for .abstract = true, and be misled. The initiated will be >> annoyed instead, because grepping for *absence* of .instance_size = is >> bothersome. >> >> I suspect life could be easier going forward if we instead required >> .abstract = true for interfaces, and enforced it with >> assert(ti->instance_size || ti->abstract) here. > I was doing that before deciding to change type_initialize(). I > think I still have the commit in my git reflog, I will recover it > and submit it as v3. I think it's worse. Interfaces are abstract by definition. Requiring ".abstract = true" makes things less intuitive. v2 seems good. Paolo