Re: [PATCH v3 2/9] pnv/xive2: Structure/define alignment changes

["Cédric Le Goater" <clg@kaod.org>]

On 7/16/24 21:56, Michael Kowal wrote:
> Made changes to some structure and define elements to ease review in
> next patchset.
> 
> Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.

> ---
>   hw/intc/pnv_xive2.c | 30 +++++++++++++++---------------
>   1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
> index af9ab68fc6..08b6da78fb 100644
> --- a/hw/intc/pnv_xive2.c
> +++ b/hw/intc/pnv_xive2.c
> @@ -45,16 +45,16 @@ typedef struct XiveVstInfo {
>   
>   static const XiveVstInfo vst_infos[] = {
>   
> -    [VST_EAS]  = { "EAT",  sizeof(Xive2Eas),  16 },
> -    [VST_ESB]  = { "ESB",  1,                  16 },
> -    [VST_END]  = { "ENDT", sizeof(Xive2End),  16 },
> +    [VST_EAS]  = { "EAT",  sizeof(Xive2Eas),     16 },
> +    [VST_ESB]  = { "ESB",  1,                    16 },
> +    [VST_END]  = { "ENDT", sizeof(Xive2End),     16 },
>   
> -    [VST_NVP]  = { "NVPT", sizeof(Xive2Nvp),  16 },
> -    [VST_NVG]  = { "NVGT", sizeof(Xive2Nvgc), 16 },
> -    [VST_NVC]  = { "NVCT", sizeof(Xive2Nvgc), 16 },
> +    [VST_NVP]  = { "NVPT", sizeof(Xive2Nvp),     16 },
> +    [VST_NVG]  = { "NVGT", sizeof(Xive2Nvgc),    16 },
> +    [VST_NVC]  = { "NVCT", sizeof(Xive2Nvgc),    16 },
>   
> -    [VST_IC]  =  { "IC",   1 /* ? */         , 16 }, /* Topology # */
> -    [VST_SYNC] = { "SYNC", 1 /* ? */         , 16 }, /* Topology # */
> +    [VST_IC]  =  { "IC",   1, /* ? */            16 }, /* Topology # */
> +    [VST_SYNC] = { "SYNC", 1, /* ? */            16 }, /* Topology # */
>   
>       /*
>        * This table contains the backing store pages for the interrupt
> @@ -1720,13 +1720,13 @@ static const MemoryRegionOps pnv_xive2_ic_lsi_ops = {
>   /*
>    * Sync MMIO page (write only)
>    */
> -#define PNV_XIVE2_SYNC_IPI      0x000
> -#define PNV_XIVE2_SYNC_HW       0x080
> -#define PNV_XIVE2_SYNC_NxC      0x100
> -#define PNV_XIVE2_SYNC_INT      0x180
> -#define PNV_XIVE2_SYNC_OS_ESC   0x200
> -#define PNV_XIVE2_SYNC_POOL_ESC 0x280
> -#define PNV_XIVE2_SYNC_HARD_ESC 0x300
> +#define PNV_XIVE2_SYNC_IPI              0x000
> +#define PNV_XIVE2_SYNC_HW               0x080
> +#define PNV_XIVE2_SYNC_NxC              0x100
> +#define PNV_XIVE2_SYNC_INT              0x180
> +#define PNV_XIVE2_SYNC_OS_ESC           0x200
> +#define PNV_XIVE2_SYNC_POOL_ESC         0x280
> +#define PNV_XIVE2_SYNC_HARD_ESC         0x300
>   
>   static uint64_t pnv_xive2_ic_sync_read(void *opaque, hwaddr offset,
>                                          unsigned size)