From: Thomas Huth <thuth@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v5 3/4] tests: add qmp/qom-set-without-value test
Date: Fri, 31 Aug 2018 08:00:45 +0200 [thread overview]
Message-ID: <b5db24e8-a4c5-6fe5-ceda-ed126a476370@redhat.com> (raw)
In-Reply-To: <20180830155810.17629-4-marcandre.lureau@redhat.com>
On 2018-08-30 17:58, Marc-André Lureau wrote:
> test_qom_set_without_value() is about a bug in infrastructure used by
> the QMP core, fixed in commit c489780203. We covered the bug in
> infrastructure unit tests (commit bce3035a44). I wrote that test
> earlier, to cover QMP level as well, the test could go into qmp-test.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/qmp-test.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-08-31 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 15:58 [Qemu-devel] [PATCH v5 0/4] tests: add a few QMP-related tests Marc-André Lureau
2018-08-30 15:58 ` [Qemu-devel] [PATCH v5 1/4] tests: add qmp_assert_error_class() Marc-André Lureau
2018-08-31 5:50 ` Thomas Huth
2018-08-30 15:58 ` [Qemu-devel] [PATCH v5 2/4] tests: add qmp/object-add-without-props test Marc-André Lureau
2018-08-31 5:58 ` Thomas Huth
2018-08-30 15:58 ` [Qemu-devel] [PATCH v5 3/4] tests: add qmp/qom-set-without-value test Marc-André Lureau
2018-08-31 6:00 ` Thomas Huth [this message]
2018-08-30 15:58 ` [Qemu-devel] [PATCH v5 4/4] tests: add a qmp success-response test Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5db24e8-a4c5-6fe5-ceda-ed126a476370@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).