[PATCH 00/12] Replace FSF postal address with licenses URL

[PATCH 00/12] Replace FSF postal address with licenses URL

[Sean Wei]

The boiler-plate licence headers in several parts of QEMU still contain
the obsolete “51 Franklin Street" contact line.

The Free Software Foundation now recommends using the canonical URL:

    https://www.gnu.org/licenses/


This patch updates those headers. The patches are comment-only;
no source code changes.

Please review and let me know if any patch should be split, squashed
or dropped. This is my first patch for the QEMU project, so any
feedback is greatly appreciated.

Thanks to Thomas Huth <thuth@redhat.com> for proposing this issue and
outlining the steps, and to Daniel P. Berrangé <berrange@redhat.com>
for the clarifications.


Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2438

Signed-off-by: Sean Wei <me@sean.taipei>

--

Sean Wei (12):
  COPYING: replace FSF postal address with licenses URL
  linux-headers: replace FSF postal address with licenses URL
  libdecnumber: replace FSF postal address with licenses URL
  include/libdecnumber: replace FSF postal address with licenses URL
  include/hw: replace FSF postal address with licenses URL
  include/qemu: replace FSF postal address with licenses URL
  util/rcu.c: replace FSF postal address with licenses URL
  hw: replace FSF postal address with licenses URL
  scripts: replace FSF postal address with licenses URL
  contrib: replace FSF postal address with licenses URL
  target/xtensa: replace FSF postal address with licenses URL
  target/i386/emulate: replace FSF postal address with licenses URL

 COPYING                                        | 5 ++---
 COPYING.LIB                                    | 5 ++---
 contrib/elf2dmp/pdb.c                          | 4 ++--
 hw/net/vmxnet3.h                               | 4 ++--
 hw/scsi/vmw_pvscsi.h                           | 4 ++--
 include/hw/i2c/aspeed_i2c.h                    | 3 +--
 include/hw/pci/pci_bridge.h                    | 4 ++--
 include/hw/timer/aspeed_timer.h                | 3 +--
 include/libdecnumber/dconfig.h                 | 5 ++---
 include/libdecnumber/decContext.h              | 5 ++---
 include/libdecnumber/decDPD.h                  | 5 ++---
 include/libdecnumber/decNumber.h               | 5 ++---
 include/libdecnumber/decNumberLocal.h          | 5 ++---
 include/libdecnumber/dpd/decimal128.h          | 5 ++---
 include/libdecnumber/dpd/decimal128Local.h     | 5 ++---
 include/libdecnumber/dpd/decimal32.h           | 5 ++---
 include/libdecnumber/dpd/decimal64.h           | 5 ++---
 include/qemu/rcu.h                             | 4 ++--
 include/qemu/rcu_queue.h                       | 4 ++--
 libdecnumber/decContext.c                      | 5 ++---
 libdecnumber/decNumber.c                       | 5 ++---
 libdecnumber/dpd/decimal128.c                  | 5 ++---
 libdecnumber/dpd/decimal32.c                   | 5 ++---
 libdecnumber/dpd/decimal64.c                   | 5 ++---
 linux-headers/LICENSES/preferred/GPL-2.0       | 5 ++---
 linux-headers/asm-arm/kvm.h                    | 4 ++--
 linux-headers/asm-powerpc/kvm.h                | 4 ++--
 scripts/device-crash-test                      | 3 +--
 target/i386/emulate/x86_emu.c                  | 4 ++--
 target/i386/emulate/x86_flags.c                | 4 ++--
 target/i386/emulate/x86_flags.h                | 4 ++--
 target/xtensa/core-dc232b/gdb-config.c.inc     | 5 ++---
 target/xtensa/core-dc232b/xtensa-modules.c.inc | 5 ++---
 target/xtensa/core-fsf/xtensa-modules.c.inc    | 5 ++---
 util/rcu.c                                     | 4 ++--
 35 files changed, 67 insertions(+), 90 deletions(-)

-- 
2.49.0

[PATCH 01/12] COPYING: replace FSF postal address with licenses URL

[Sean Wei]

The license text in COPYING (GPLv2), COPYING.LIB (LGPLv2.1),
and the linux-headers/LICENSES/preferred/GPL-2.0 file are
referenced to the obsolete FSF postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 COPYING                                  | 5 ++---
 COPYING.LIB                              | 5 ++---
 linux-headers/LICENSES/preferred/GPL-2.0 | 5 ++---
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/COPYING b/COPYING
index 00ccfbb628..8095135d50 100644
--- a/COPYING
+++ b/COPYING
@@ -2,7 +2,7 @@
 		       Version 2, June 1991
 
  Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ <https://fsf.org/>
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -304,8 +304,7 @@ the "copyright" line and a pointer to where the full notice is found.
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License along
-    with this program; if not, write to the Free Software Foundation, Inc.,
-    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+    with this program; if not, see <https://www.gnu.org/licenses/>.
 
 Also add information on how to contact you by electronic and paper mail.
 
diff --git a/COPYING.LIB b/COPYING.LIB
index 4362b49151..99f47575b5 100644
--- a/COPYING.LIB
+++ b/COPYING.LIB
@@ -2,7 +2,7 @@
                        Version 2.1, February 1999
 
  Copyright (C) 1991, 1999 Free Software Foundation, Inc.
- 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ <https://fsf.org/>
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -484,8 +484,7 @@ convey the exclusion of warranty; and each file should have at least the
     Lesser General Public License for more details.
 
     You should have received a copy of the GNU Lesser General Public
-    License along with this library; if not, write to the Free Software
-    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+    License along with this library; if not, see <https://www.gnu.org/licenses/>.
 
 Also add information on how to contact you by electronic and paper mail.
 
diff --git a/linux-headers/LICENSES/preferred/GPL-2.0 b/linux-headers/LICENSES/preferred/GPL-2.0
index ff0812fd89..10248a619e 100644
--- a/linux-headers/LICENSES/preferred/GPL-2.0
+++ b/linux-headers/LICENSES/preferred/GPL-2.0
@@ -21,7 +21,7 @@ License-Text:
 		       Version 2, June 1991
 
  Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-                       51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ <https://fsf.org/>
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -323,8 +323,7 @@ the "copyright" line and a pointer to where the full notice is found.
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+    along with this program; if not, see <https://www.gnu.org/licenses/>.
 
 
 Also add information on how to contact you by electronic and paper mail.
-- 
2.49.0

[PATCH 02/12] linux-headers: replace FSF postal address with licenses URL

[Sean Wei]

The GPLv2 boiler-plate in asm-arm/kvm.h and asm-powerpc/kvm.h still
contained the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 linux-headers/asm-arm/kvm.h     | 4 ++--
 linux-headers/asm-powerpc/kvm.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/linux-headers/asm-arm/kvm.h b/linux-headers/asm-arm/kvm.h
index 0db5644e27..a8bb1aa42a 100644
--- a/linux-headers/asm-arm/kvm.h
+++ b/linux-headers/asm-arm/kvm.h
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ * along with this program; if not, see
+ * <https://www.gnu.org/licenses/>.
  */
 
 #ifndef __ARM_KVM_H__
diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm.h
index eaeda00178..83faa7fae3 100644
--- a/linux-headers/asm-powerpc/kvm.h
+++ b/linux-headers/asm-powerpc/kvm.h
@@ -10,8 +10,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ * along with this program; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * Copyright IBM Corp. 2007
  *
-- 
2.49.0

[PATCH 03/12] libdecnumber: replace FSF postal address with licenses URL

[Sean Wei]

Some of the GPLv2 boiler-plate still contained the
obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 libdecnumber/decContext.c     | 5 ++---
 libdecnumber/decNumber.c      | 5 ++---
 libdecnumber/dpd/decimal128.c | 5 ++---
 libdecnumber/dpd/decimal32.c  | 5 ++---
 libdecnumber/dpd/decimal64.c  | 5 ++---
 5 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/libdecnumber/decContext.c b/libdecnumber/decContext.c
index 1956edf0a7..d99b08026c 100644
--- a/libdecnumber/decContext.c
+++ b/libdecnumber/decContext.c
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal Context module					      */
diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c
index 31282adafd..4b57d8a6fe 100644
--- a/libdecnumber/decNumber.c
+++ b/libdecnumber/decNumber.c
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal Number arithmetic module				      */
diff --git a/libdecnumber/dpd/decimal128.c b/libdecnumber/dpd/decimal128.c
index ca4764e547..1064fb25e0 100644
--- a/libdecnumber/dpd/decimal128.c
+++ b/libdecnumber/dpd/decimal128.c
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 128-bit format module				      */
diff --git a/libdecnumber/dpd/decimal32.c b/libdecnumber/dpd/decimal32.c
index 53f29789d7..34ff0fe959 100644
--- a/libdecnumber/dpd/decimal32.c
+++ b/libdecnumber/dpd/decimal32.c
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 32-bit format module					      */
diff --git a/libdecnumber/dpd/decimal64.c b/libdecnumber/dpd/decimal64.c
index 290dbe8177..11e0674fa7 100644
--- a/libdecnumber/dpd/decimal64.c
+++ b/libdecnumber/dpd/decimal64.c
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 64-bit format module					      */
-- 
2.49.0

[PATCH 04/12] include/libdecnumber: replace FSF postal address with licenses URL

[Sean Wei]

Some of the GPLv2 boiler-plate still contained the
obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 include/libdecnumber/dconfig.h             | 5 ++---
 include/libdecnumber/decContext.h          | 5 ++---
 include/libdecnumber/decDPD.h              | 5 ++---
 include/libdecnumber/decNumber.h           | 5 ++---
 include/libdecnumber/decNumberLocal.h      | 5 ++---
 include/libdecnumber/dpd/decimal128.h      | 5 ++---
 include/libdecnumber/dpd/decimal128Local.h | 5 ++---
 include/libdecnumber/dpd/decimal32.h       | 5 ++---
 include/libdecnumber/dpd/decimal64.h       | 5 ++---
 9 files changed, 18 insertions(+), 27 deletions(-)

diff --git a/include/libdecnumber/dconfig.h b/include/libdecnumber/dconfig.h
index 2bc0ba7f14..e67ecc1b5f 100644
--- a/include/libdecnumber/dconfig.h
+++ b/include/libdecnumber/dconfig.h
@@ -23,9 +23,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 
 #if HOST_BIG_ENDIAN
diff --git a/include/libdecnumber/decContext.h b/include/libdecnumber/decContext.h
index cea6e4279e..5bb64e1332 100644
--- a/include/libdecnumber/decContext.h
+++ b/include/libdecnumber/decContext.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal Context module header				      */
diff --git a/include/libdecnumber/decDPD.h b/include/libdecnumber/decDPD.h
index 26a21ec8ed..8eb455277b 100644
--- a/include/libdecnumber/decDPD.h
+++ b/include/libdecnumber/decDPD.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------------ */
 /* Binary Coded Decimal and Densely Packed Decimal conversion lookup tables */
diff --git a/include/libdecnumber/decNumber.h b/include/libdecnumber/decNumber.h
index 41bc2a0d36..bf37af83e6 100644
--- a/include/libdecnumber/decNumber.h
+++ b/include/libdecnumber/decNumber.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal Number arithmetic module header			      */
diff --git a/include/libdecnumber/decNumberLocal.h b/include/libdecnumber/decNumberLocal.h
index 6198ca8593..0959f6606b 100644
--- a/include/libdecnumber/decNumberLocal.h
+++ b/include/libdecnumber/decNumberLocal.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* decNumber package local type, tuning, and macro definitions	      */
diff --git a/include/libdecnumber/dpd/decimal128.h b/include/libdecnumber/dpd/decimal128.h
index aff261e556..c57180baf8 100644
--- a/include/libdecnumber/dpd/decimal128.h
+++ b/include/libdecnumber/dpd/decimal128.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 128-bit format module header				      */
diff --git a/include/libdecnumber/dpd/decimal128Local.h b/include/libdecnumber/dpd/decimal128Local.h
index 9765427719..2948ab2534 100644
--- a/include/libdecnumber/dpd/decimal128Local.h
+++ b/include/libdecnumber/dpd/decimal128Local.h
@@ -23,9 +23,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 #if !defined(DECIMAL128LOCAL)
 
diff --git a/include/libdecnumber/dpd/decimal32.h b/include/libdecnumber/dpd/decimal32.h
index 6cb9e43620..9a17933497 100644
--- a/include/libdecnumber/dpd/decimal32.h
+++ b/include/libdecnumber/dpd/decimal32.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 32-bit format module header				      */
diff --git a/include/libdecnumber/dpd/decimal64.h b/include/libdecnumber/dpd/decimal64.h
index f29e57064d..5c3d0bb43c 100644
--- a/include/libdecnumber/dpd/decimal64.h
+++ b/include/libdecnumber/dpd/decimal64.h
@@ -24,9 +24,8 @@
    for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING.  If not, see
+   <https://www.gnu.org/licenses/>.  */
 
 /* ------------------------------------------------------------------ */
 /* Decimal 64-bit format module header				      */
-- 
2.49.0

[PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Sean Wei]

Some of the GPLv2 boiler-plate still contained the
obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 include/hw/i2c/aspeed_i2c.h     | 3 +--
 include/hw/pci/pci_bridge.h     | 4 ++--
 include/hw/timer/aspeed_timer.h | 3 +--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h
index 2c4c81bd20..2daacc10ce 100644
--- a/include/hw/i2c/aspeed_i2c.h
+++ b/include/hw/i2c/aspeed_i2c.h
@@ -14,8 +14,7 @@
  *  GNU General Public License for more details.
  *
  *  You should have received a copy of the GNU General Public License along
- *  with this program; if not, write to the Free Software Foundation, Inc.,
- *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *  with this program; if not, see <https://www.gnu.org/licenses/>.
  */
 
 #ifndef ASPEED_I2C_H
diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h
index b0f5204d80..8cdacbc4e1 100644
--- a/include/hw/pci/pci_bridge.h
+++ b/include/hw/pci/pci_bridge.h
@@ -14,8 +14,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ * along with this program; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * split out pci bus specific stuff from pci.[hc] to pci_bridge.[hc]
  * Copyright (c) 2009 Isaku Yamahata <yamahata at valinux co jp>
diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h
index 767cae4b05..a850625a05 100644
--- a/include/hw/timer/aspeed_timer.h
+++ b/include/hw/timer/aspeed_timer.h
@@ -16,8 +16,7 @@
  *  GNU General Public License for more details.
  *
  *  You should have received a copy of the GNU General Public License along
- *  with this program; if not, write to the Free Software Foundation, Inc.,
- *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *  with this program; if not, see <https://www.gnu.org/licenses/>.
  */
 #ifndef ASPEED_TIMER_H
 #define ASPEED_TIMER_H
-- 
2.49.0

[PATCH 06/12] include/qemu: replace FSF postal address with licenses URL

[Sean Wei]

The LGPLv2.1 boiler-plate in rcu.h and rcu_queue.h still
contained the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 include/qemu/rcu.h       | 4 ++--
 include/qemu/rcu_queue.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index fea058aa9f..020dbe4d8b 100644
--- a/include/qemu/rcu.h
+++ b/include/qemu/rcu.h
@@ -17,8 +17,8 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * License along with this library; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * IBM's contributions to this file may be relicensed under LGPLv2 or later.
  */
diff --git a/include/qemu/rcu_queue.h b/include/qemu/rcu_queue.h
index 4e6298d473..bfd5900fda 100644
--- a/include/qemu/rcu_queue.h
+++ b/include/qemu/rcu_queue.h
@@ -17,8 +17,8 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * License along with this library; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * Copyright (c) 2013 Mike D. Day, IBM Corporation.
  *
-- 
2.49.0

[PATCH 07/12] util/rcu.c: replace FSF postal address with licenses URL

[Sean Wei]

The LGPLv2.1 boiler-plate in util/rcu.c still contained
the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 util/rcu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/rcu.c b/util/rcu.c
index fa32c942e4..b703c86f15 100644
--- a/util/rcu.c
+++ b/util/rcu.c
@@ -20,8 +20,8 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * License along with this library; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * IBM's contributions to this file may be relicensed under LGPLv2 or later.
  */
-- 
2.49.0

[PATCH 08/12] hw: replace FSF postal address with licenses URL

[Sean Wei]

The GPLv2 boiler-plate in vmxnet3.h and vmw_pvscsi.h still
contained the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 hw/net/vmxnet3.h     | 4 ++--
 hw/scsi/vmw_pvscsi.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/net/vmxnet3.h b/hw/net/vmxnet3.h
index f9283f9e7b..dbc69d5fb6 100644
--- a/hw/net/vmxnet3.h
+++ b/hw/net/vmxnet3.h
@@ -63,8 +63,8 @@
  * details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ * along with this program; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * The full GNU General Public License is included in this distribution in
  * the file called "COPYING".
diff --git a/hw/scsi/vmw_pvscsi.h b/hw/scsi/vmw_pvscsi.h
index 17fcf66273..a3ae517e19 100644
--- a/hw/scsi/vmw_pvscsi.h
+++ b/hw/scsi/vmw_pvscsi.h
@@ -14,8 +14,8 @@
  * details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ * along with this program; if not, see
+ * <https://www.gnu.org/licenses/>.
  *
  * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
  *
-- 
2.49.0

[PATCH 09/12] scripts: replace FSF postal address with licenses URL

[Sean Wei]

The GPLv2 boiler-plate in scripts/device-crash-test still
contained the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 scripts/device-crash-test | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index da8b56edd9..1ecb9663ae 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -16,8 +16,7 @@
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License along
-# with this program; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# with this program; if not, see <https://www.gnu.org/licenses/>.
 
 """
 Run QEMU with all combinations of -machine and -device types,
-- 
2.49.0

[PATCH 10/12] contrib: replace FSF postal address with licenses URL

[Sean Wei]

The LGPLv2.1 boiler-plate in pdb.c file still contained
the obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 contrib/elf2dmp/pdb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c
index 492aca4434..47c5126fb8 100644
--- a/contrib/elf2dmp/pdb.c
+++ b/contrib/elf2dmp/pdb.c
@@ -14,8 +14,8 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ * License along with this library; if not, see
+ * <https://www.gnu.org/licenses/>.
  */
 
 #include "qemu/osdep.h"
-- 
2.49.0

[PATCH 11/12] target/xtensa: replace FSF postal address with licenses URL

[Sean Wei]

Some of the GPLv2 boiler-plate still contained the
obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 target/xtensa/core-dc232b/gdb-config.c.inc     | 5 ++---
 target/xtensa/core-dc232b/xtensa-modules.c.inc | 5 ++---
 target/xtensa/core-fsf/xtensa-modules.c.inc    | 5 ++---
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/target/xtensa/core-dc232b/gdb-config.c.inc b/target/xtensa/core-dc232b/gdb-config.c.inc
index d87168628b..8c88caef59 100644
--- a/target/xtensa/core-dc232b/gdb-config.c.inc
+++ b/target/xtensa/core-dc232b/gdb-config.c.inc
@@ -15,9 +15,8 @@
    GNU General Public License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 51 Franklin Street, Fifth Floor,
-   Boston, MA 02110-1301, USA.  */
+   along with this program; if not, see
+   <https://www.gnu.org/licenses/>.  */
 
   XTREG(0,   0, 32, 4, 4, 0x0020, 0x0006, -2, 9, 0x0100, pc,
           0, 0, 0, 0, 0, 0)
diff --git a/target/xtensa/core-dc232b/xtensa-modules.c.inc b/target/xtensa/core-dc232b/xtensa-modules.c.inc
index 164df3b1a4..bb9ebd24b8 100644
--- a/target/xtensa/core-dc232b/xtensa-modules.c.inc
+++ b/target/xtensa/core-dc232b/xtensa-modules.c.inc
@@ -14,9 +14,8 @@
    General Public License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with this program; if not, see
+   <https://www.gnu.org/licenses/>.  */
 
 #include "qemu/osdep.h"
 #include "xtensa-isa.h"
diff --git a/target/xtensa/core-fsf/xtensa-modules.c.inc b/target/xtensa/core-fsf/xtensa-modules.c.inc
index c32683ff77..531f5e2b7e 100644
--- a/target/xtensa/core-fsf/xtensa-modules.c.inc
+++ b/target/xtensa/core-fsf/xtensa-modules.c.inc
@@ -14,9 +14,8 @@
    General Public License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with this program; if not, see
+   <https://www.gnu.org/licenses/>.  */
 
 #include "qemu/osdep.h"
 #include "xtensa-isa.h"
-- 
2.49.0

[PATCH 12/12] target/i386/emulate: replace FSF postal address with licenses URL

[Sean Wei]

Some of the LGPLv2.1 boiler-plate still contained the
obsolete "51 Franklin Street" postal address.

Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/

Signed-off-by: Sean Wei <me@sean.taipei>
---
 target/i386/emulate/x86_emu.c   | 4 ++--
 target/i386/emulate/x86_flags.c | 4 ++--
 target/i386/emulate/x86_flags.h | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c
index 4890e0a4e5..db7a7f7437 100644
--- a/target/i386/emulate/x86_emu.c
+++ b/target/i386/emulate/x86_emu.c
@@ -31,8 +31,8 @@
 //  Lesser General Public License for more details.
 //
 //  You should have received a copy of the GNU Lesser General Public
-//  License along with this library; if not, write to the Free Software
-//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
+//  License along with this library; if not, see
+//  <https://www.gnu.org/licenses/>.
 /////////////////////////////////////////////////////////////////////////
 
 #include "qemu/osdep.h"
diff --git a/target/i386/emulate/x86_flags.c b/target/i386/emulate/x86_flags.c
index cc138c7749..6592193b5e 100644
--- a/target/i386/emulate/x86_flags.c
+++ b/target/i386/emulate/x86_flags.c
@@ -14,8 +14,8 @@
 //  Lesser General Public License for more details.
 //
 //  You should have received a copy of the GNU Lesser General Public
-//  License along with this library; if not, write to the Free Software
-//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
+//  License along with this library; if not, see
+//  <https://www.gnu.org/licenses/>.
 /////////////////////////////////////////////////////////////////////////
 /*
  * flags functions
diff --git a/target/i386/emulate/x86_flags.h b/target/i386/emulate/x86_flags.h
index 28b008e577..a395c837a0 100644
--- a/target/i386/emulate/x86_flags.h
+++ b/target/i386/emulate/x86_flags.h
@@ -14,8 +14,8 @@
 //  Lesser General Public License for more details.
 //
 //  You should have received a copy of the GNU Lesser General Public
-//  License along with this library; if not, write to the Free Software
-//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
+//  License along with this library; if not, see
+//  <https://www.gnu.org/licenses/>.
 /////////////////////////////////////////////////////////////////////////
 /*
  * x86 eflags functions
-- 
2.49.0

Re: [PATCH 11/12] target/xtensa: replace FSF postal address with licenses URL

[Max Filippov]

On Fri, Jun 13, 2025 at 9:54 AM Sean Wei <me@sean.taipei> wrote:
>
> Some of the GPLv2 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
>
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>  target/xtensa/core-dc232b/gdb-config.c.inc     | 5 ++---
>  target/xtensa/core-dc232b/xtensa-modules.c.inc | 5 ++---
>  target/xtensa/core-fsf/xtensa-modules.c.inc    | 5 ++---
>  3 files changed, 6 insertions(+), 9 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

Hello Sean,

On 6/13/25 18:44, Sean Wei wrote:
> Some of the GPLv2 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>

Instead,  I would remove the license boiler plate and add :

   SPDX-License-Identifier: GPL-2.0-or-later

Thanks,

C.

> ---
>   include/hw/i2c/aspeed_i2c.h     | 3 +--
>   include/hw/pci/pci_bridge.h     | 4 ++--
>   include/hw/timer/aspeed_timer.h | 3 +--
>   3 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h
> index 2c4c81bd20..2daacc10ce 100644
> --- a/include/hw/i2c/aspeed_i2c.h
> +++ b/include/hw/i2c/aspeed_i2c.h
> @@ -14,8 +14,7 @@
>    *  GNU General Public License for more details.
>    *
>    *  You should have received a copy of the GNU General Public License along
> - *  with this program; if not, write to the Free Software Foundation, Inc.,
> - *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + *  with this program; if not, see <https://www.gnu.org/licenses/>.
>    */
>   
>   #ifndef ASPEED_I2C_H
> diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h
> index b0f5204d80..8cdacbc4e1 100644
> --- a/include/hw/pci/pci_bridge.h
> +++ b/include/hw/pci/pci_bridge.h
> @@ -14,8 +14,8 @@
>    * GNU General Public License for more details.
>    *
>    * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> + * along with this program; if not, see
> + * <https://www.gnu.org/licenses/>.
>    *
>    * split out pci bus specific stuff from pci.[hc] to pci_bridge.[hc]
>    * Copyright (c) 2009 Isaku Yamahata <yamahata at valinux co jp>
> diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h
> index 767cae4b05..a850625a05 100644
> --- a/include/hw/timer/aspeed_timer.h
> +++ b/include/hw/timer/aspeed_timer.h
> @@ -16,8 +16,7 @@
>    *  GNU General Public License for more details.
>    *
>    *  You should have received a copy of the GNU General Public License along
> - *  with this program; if not, write to the Free Software Foundation, Inc.,
> - *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + *  with this program; if not, see <https://www.gnu.org/licenses/>.
>    */
>   #ifndef ASPEED_TIMER_H
>   #define ASPEED_TIMER_H

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Sean Wei]

Hi Cédric,

Thank you for the quick review and for suggesting the SPDX approach.

On Sat, Jun 14, 2025 at 1:36 AM Cédric Le Goater <clg@kaod.org> wrote:
>
> Instead,  I would remove the license boiler plate and add :
>
>    SPDX-License-Identifier: GPL-2.0-or-later
>

Before we respin the patch, could you please confirm the scope below?


1. For the two headers currently under review
   (aspeed_i2c.h and aspeed_timer.h)

   I will drop the multi-line GPL boiler-plate and replace it
   with SPDX line, while keeping the copyright statements.


2. For the other ASPEED-maintained files

       hw/*/*aspeed*
       include/hw/*/*aspeed*
       tests/*/*aspeed*

   Would you prefer to convert them as well? If so, I'd prefer to
   send a dedicated patch series after this one.


3. Replacement rule:

   * multi-line GPL boiler-plate
     -> replace with SPDX

   * existing short two-line notice
       This code is licensed under the GPL version 2 or later.
       See the COPYING file in the top-level directory.
     -> leave unchanged

   Is that correct?


4. If we do the wider sweep,
   should MIT-licensed ASPEED files also be updated by replacing
   their boiler-plate with SPDX identifier in the same patch series?


Please let me know what works best for you and I will send v2 accordingly.

Thanks again for the guidance,
Sean Wei

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

Hello Sean,

+ Daniel

On 6/14/25 14:58, Sean Wei wrote:
> Hi Cédric,
> 
> Thank you for the quick review and for suggesting the SPDX approach.
> 
> On Sat, Jun 14, 2025 at 1:36 AM Cédric Le Goater <clg@kaod.org> wrote:
>>
>> Instead,  I would remove the license boiler plate and add :
>>
>>     SPDX-License-Identifier: GPL-2.0-or-later
>>
> 
> Before we respin the patch, could you please confirm the scope below?
> 
> 
> 1. For the two headers currently under review
>     (aspeed_i2c.h and aspeed_timer.h)
> 
>     I will drop the multi-line GPL boiler-plate and replace it
>     with SPDX line, while keeping the copyright statements.

Fine with me.

> 2. For the other ASPEED-maintained files
> 
>         hw/*/*aspeed*
>         include/hw/*/*aspeed*
>         tests/*/*aspeed*
> 
>     Would you prefer to convert them as well? If so, I'd prefer to
>     send a dedicated patch series after this one.

OK. As you wish.

I think you can convert all QEMU files while at it.  See:

   https://lore.kernel.org/qemu-devel/20250519171004.352636-10-berrange@redhat.com/


> 3. Replacement rule:
> 
>     * multi-line GPL boiler-plate
>       -> replace with SPDX
> 
>     * existing short two-line notice
>         This code is licensed under the GPL version 2 or later.
>         See the COPYING file in the top-level directory.
>       -> leave unchanged

Please replace with SPDX too.
  
>     Is that correct?
> 
> 
> 4. If we do the wider sweep,
>     should MIT-licensed ASPEED files also be updated by replacing

Are there any ?

Thanks,

C.


>     their boiler-plate with SPDX identifier in the same patch series?
> 
> 
> Please let me know what works best for you and I will send v2 accordingly.
> 
> Thanks again for the guidance,
> Sean Wei

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Sean Wei]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Hi Cédric,

Thanks for pointing me to the earlier thread, moving to
the `SPDX-License-Identifier` tags is the better long-term fix.


 > I think you can convert all QEMU files while at it.

To keep traffic on qemu-devel@ manageable, I'd like to work
subtree by subtree, following the sections in MAINTAINERS.


 > Are there any MIT-licensed files?

Just a handful in the ASPEED code base using MIT:

     hw/ssi/aspeed_smc.c
     include/hw/ssi/aspeed_smc.h
     tests/qtest/aspeed_gpio-test.c
     tests/qtest/aspeed_smc-test.c
     tests/qtest/aspeed-smc-utils.c
     tests/qtest/aspeed-smc-utils.h


## Proposed steps

1. Start with the ASPEED BMC subtree.

2. Split commits by path and header style.
    path: hw/, include/hw/, tests/
    license: GPL-2.0-or-later, GPL-2.0-only, MIT
    style: boiler plate, see COPYING

3. Drop the boiler-plate, replace with the correct
    SPDX-License-Identifier, without changing code.

Does this approach sound reasonable for you?


Thanks again for the guidance!

Best regards,
Sean Wei

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4894 bytes --]

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

Hello Sean

On 6/14/25 22:22, Sean Wei wrote:
> Hi Cédric,
> 
> Thanks for pointing me to the earlier thread, moving to
> the `SPDX-License-Identifier` tags is the better long-term fix.
> 
> 
>  > I think you can convert all QEMU files while at it.
> 
> To keep traffic on qemu-devel@ manageable, I'd like to work
> subtree by subtree, following the sections in MAINTAINERS.
> 
> 
>  > Are there any MIT-licensed files?
> 
> Just a handful in the ASPEED code base using MIT:
> 
>      hw/ssi/aspeed_smc.c
>      include/hw/ssi/aspeed_smc.h
>      tests/qtest/aspeed_gpio-test.c
>      tests/qtest/aspeed_smc-test.c
>      tests/qtest/aspeed-smc-utils.c
>      tests/qtest/aspeed-smc-utils.h

Oh and I am the one that did that 9y ago. I think I was inspired by
the PPC series source files I was working on at the time.

> 
> ## Proposed steps
> 
> 1. Start with the ASPEED BMC subtree.
> 
> 2. Split commits by path and header style.
>     path: hw/, include/hw/, tests/
>     license: GPL-2.0-or-later, GPL-2.0-only, MIT
>     style: boiler plate, see COPYING
> > 3. Drop the boiler-plate, replace with the correct
>     SPDX-License-Identifier, without changing code.
> 
> Does this approach sound reasonable for you?

LGTM. I will merge these changes through the aspeed tree.

Thanks,

C.

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Daniel P. Berrangé]

On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
> Hello Sean,
> 
> On 6/13/25 18:44, Sean Wei wrote:
> > Some of the GPLv2 boiler-plate still contained the
> > obsolete "51 Franklin Street" postal address.
> > 
> > Replace it with the canonical GNU licenses URL recommended by the FSF:
> > https://www.gnu.org/licenses/
> > 
> > Signed-off-by: Sean Wei <me@sean.taipei>
> 
> Instead,  I would remove the license boiler plate and add :
> 
>   SPDX-License-Identifier: GPL-2.0-or-later

This is *NOT* something we are doing for existing code sources,
unless the person removing it is the exclusive copyright
holder on the file.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Daniel P. Berrangé]

On Sat, Jun 14, 2025 at 05:33:42PM +0200, Cédric Le Goater wrote:
> Hello Sean,
> 
> + Daniel
> 
> On 6/14/25 14:58, Sean Wei wrote:
> > Hi Cédric,
> > 
> > Thank you for the quick review and for suggesting the SPDX approach.
> > 
> > On Sat, Jun 14, 2025 at 1:36 AM Cédric Le Goater <clg@kaod.org> wrote:
> > > 
> > > Instead,  I would remove the license boiler plate and add :
> > > 
> > >     SPDX-License-Identifier: GPL-2.0-or-later
> > > 
> > 
> > Before we respin the patch, could you please confirm the scope below?
> > 
> > 
> > 1. For the two headers currently under review
> >     (aspeed_i2c.h and aspeed_timer.h)
> > 
> >     I will drop the multi-line GPL boiler-plate and replace it
> >     with SPDX line, while keeping the copyright statements.
> 
> Fine with me.
> 
> > 2. For the other ASPEED-maintained files
> > 
> >         hw/*/*aspeed*
> >         include/hw/*/*aspeed*
> >         tests/*/*aspeed*
> > 
> >     Would you prefer to convert them as well? If so, I'd prefer to
> >     send a dedicated patch series after this one.
> 
> OK. As you wish.
> 
> I think you can convert all QEMU files while at it.  See:
> 
>   https://lore.kernel.org/qemu-devel/20250519171004.352636-10-berrange@redhat.com/

Note that rules triggers *exclusively* for new files, not for any
existing files.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

On 6/16/25 09:13, Daniel P. Berrangé wrote:
> On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
>> Hello Sean,
>>
>> On 6/13/25 18:44, Sean Wei wrote:
>>> Some of the GPLv2 boiler-plate still contained the
>>> obsolete "51 Franklin Street" postal address.
>>>
>>> Replace it with the canonical GNU licenses URL recommended by the FSF:
>>> https://www.gnu.org/licenses/
>>>
>>> Signed-off-by: Sean Wei <me@sean.taipei>
>>
>> Instead,  I would remove the license boiler plate and add :
>>
>>    SPDX-License-Identifier: GPL-2.0-or-later
> 
> This is *NOT* something we are doing for existing code sources,
> unless the person removing it is the exclusive copyright
> holder on the file.
Ah. So I misunderstood.

How is license boiler plate different from the SPDX identifier tag ?

Thanks,

C.

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Daniel P. Berrangé]

On Mon, Jun 16, 2025 at 09:29:35AM +0200, Cédric Le Goater wrote:
> On 6/16/25 09:13, Daniel P. Berrangé wrote:
> > On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
> > > Hello Sean,
> > > 
> > > On 6/13/25 18:44, Sean Wei wrote:
> > > > Some of the GPLv2 boiler-plate still contained the
> > > > obsolete "51 Franklin Street" postal address.
> > > > 
> > > > Replace it with the canonical GNU licenses URL recommended by the FSF:
> > > > https://www.gnu.org/licenses/
> > > > 
> > > > Signed-off-by: Sean Wei <me@sean.taipei>
> > > 
> > > Instead,  I would remove the license boiler plate and add :
> > > 
> > >    SPDX-License-Identifier: GPL-2.0-or-later
> > 
> > This is *NOT* something we are doing for existing code sources,
> > unless the person removing it is the exclusive copyright
> > holder on the file.
> Ah. So I misunderstood.
> 
> How is license boiler plate different from the SPDX identifier tag ?

It achieves the same aims, but notice GPL clause 1

  "keep intact all the notices that refer to this License and
   to the absence of any warranty;"

and yes, some projects have none the less done a wholesale replacement of
boilerplate. I don't know how they rationalized ignoring this license
requirement. It is simpler to just preserve boilerplate as-is that to
debate the legal nuances of this.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

On 6/16/25 09:47, Daniel P. Berrangé wrote:
> On Mon, Jun 16, 2025 at 09:29:35AM +0200, Cédric Le Goater wrote:
>> On 6/16/25 09:13, Daniel P. Berrangé wrote:
>>> On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
>>>> Hello Sean,
>>>>
>>>> On 6/13/25 18:44, Sean Wei wrote:
>>>>> Some of the GPLv2 boiler-plate still contained the
>>>>> obsolete "51 Franklin Street" postal address.
>>>>>
>>>>> Replace it with the canonical GNU licenses URL recommended by the FSF:
>>>>> https://www.gnu.org/licenses/
>>>>>
>>>>> Signed-off-by: Sean Wei <me@sean.taipei>
>>>>
>>>> Instead,  I would remove the license boiler plate and add :
>>>>
>>>>     SPDX-License-Identifier: GPL-2.0-or-later
>>>
>>> This is *NOT* something we are doing for existing code sources,
>>> unless the person removing it is the exclusive copyright
>>> holder on the file.
>> Ah. So I misunderstood.
>>
>> How is license boiler plate different from the SPDX identifier tag ?
> 
> It achieves the same aims, but notice GPL clause 1
> 
>    "keep intact all the notices that refer to this License and
>     to the absence of any warranty;"
> 
> and yes, some projects have none the less done a wholesale replacement of
> boilerplate. I don't know how they rationalized ignoring this license
> requirement. It is simpler to just preserve boilerplate as-is that to
> debate the legal nuances of this.
OK. Then, let's forget about this replacement.

Thanks,

C.

Re: [PATCH 10/12] contrib: replace FSF postal address with licenses URL

[Akihiko Odaki]

On 2025/06/14 1:53, Sean Wei wrote:
> The LGPLv2.1 boiler-plate in pdb.c file still contained
> the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>

Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Sean Wei]

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

Hi Cédric & Daniel,

On 2025/6/16 3:55 AM, Cédric Le Goater wrote:
> On 6/16/25 09:47, Daniel P. Berrangé wrote:
>> On Mon, Jun 16, 2025 at 09:29:35AM +0200, Cédric Le Goater wrote:
>>> On 6/16/25 09:13, Daniel P. Berrangé wrote:
>>>> On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
>>>>> Hello Sean,
>>>>>
>>>>> On 6/13/25 18:44, Sean Wei wrote:
>>>>>> Some of the GPLv2 boiler-plate still contained the
>>>>>> obsolete "51 Franklin Street" postal address.
>>>>>>
>>>>>> Replace it with the canonical GNU licenses URL recommended by the 
>>>>>> FSF:
>>>>>> https://www.gnu.org/licenses/
>>>>>>
>>>>>> Signed-off-by: Sean Wei <me@sean.taipei>
>>>>>
>>>>> Instead,  I would remove the license boiler plate and add :
>>>>>
>>>>>     SPDX-License-Identifier: GPL-2.0-or-later
>>>>
>>>> This is *NOT* something we are doing for existing code sources,
>>>> unless the person removing it is the exclusive copyright
>>>> holder on the file.
>>> Ah. So I misunderstood.
>>>
>>> How is license boiler plate different from the SPDX identifier tag ?
>>
>> It achieves the same aims, but notice GPL clause 1
>>
>>    "keep intact all the notices that refer to this License and
>>     to the absence of any warranty;"
>>
>> and yes, some projects have none the less done a wholesale replacement of
>> boilerplate. I don't know how they rationalized ignoring this license
>> requirement. It is simpler to just preserve boilerplate as-is that to
>> debate the legal nuances of this.
> OK. Then, let's forget about this replacement.
> 
> Thanks,
> 
> C.
> 

Thank you both for the clarification! To avoid any controversy, I will 
keep the patch in its original form, only replacing the deprecated FSF 
address with the canonical GNU licenses URL.

Cédric, could you please take another look and let me know if everything 
looks good? If so, I'd be grateful if you could add a Reviewed-by tag. 
Thanks!

All the best,
Sean Wei


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4894 bytes --]

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

On 6/16/25 14:49, Sean Wei wrote:
> Hi Cédric & Daniel,
> 
> On 2025/6/16 3:55 AM, Cédric Le Goater wrote:
>> On 6/16/25 09:47, Daniel P. Berrangé wrote:
>>> On Mon, Jun 16, 2025 at 09:29:35AM +0200, Cédric Le Goater wrote:
>>>> On 6/16/25 09:13, Daniel P. Berrangé wrote:
>>>>> On Sat, Jun 14, 2025 at 07:29:09AM +0200, Cédric Le Goater wrote:
>>>>>> Hello Sean,
>>>>>>
>>>>>> On 6/13/25 18:44, Sean Wei wrote:
>>>>>>> Some of the GPLv2 boiler-plate still contained the
>>>>>>> obsolete "51 Franklin Street" postal address.
>>>>>>>
>>>>>>> Replace it with the canonical GNU licenses URL recommended by the FSF:
>>>>>>> https://www.gnu.org/licenses/
>>>>>>>
>>>>>>> Signed-off-by: Sean Wei <me@sean.taipei>
>>>>>>
>>>>>> Instead,  I would remove the license boiler plate and add :
>>>>>>
>>>>>>     SPDX-License-Identifier: GPL-2.0-or-later
>>>>>
>>>>> This is *NOT* something we are doing for existing code sources,
>>>>> unless the person removing it is the exclusive copyright
>>>>> holder on the file.
>>>> Ah. So I misunderstood.
>>>>
>>>> How is license boiler plate different from the SPDX identifier tag ?
>>>
>>> It achieves the same aims, but notice GPL clause 1
>>>
>>>    "keep intact all the notices that refer to this License and
>>>     to the absence of any warranty;"
>>>
>>> and yes, some projects have none the less done a wholesale replacement of
>>> boilerplate. I don't know how they rationalized ignoring this license
>>> requirement. It is simpler to just preserve boilerplate as-is that to
>>> debate the legal nuances of this.
>> OK. Then, let's forget about this replacement.
>>
>> Thanks,
>>
>> C.
>>
> 
> Thank you both for the clarification! To avoid any controversy, I will keep the patch in its original form, only replacing the deprecated FSF address with the canonical GNU licenses URL.

yep.

> Cédric, could you please take another look and let me know if everything looks good? If so, I'd be grateful if you could add a Reviewed-by tag. Thanks!

sure.


Thanks,

C.

Re: [PATCH 05/12] include/hw: replace FSF postal address with licenses URL

[Cédric Le Goater]

On 6/13/25 18:44, Sean Wei wrote:
> Some of the GPLv2 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   include/hw/i2c/aspeed_i2c.h     | 3 +--
>   include/hw/pci/pci_bridge.h     | 4 ++--
>   include/hw/timer/aspeed_timer.h | 3 +--
>   3 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h
> index 2c4c81bd20..2daacc10ce 100644
> --- a/include/hw/i2c/aspeed_i2c.h
> +++ b/include/hw/i2c/aspeed_i2c.h
> @@ -14,8 +14,7 @@
>    *  GNU General Public License for more details.
>    *
>    *  You should have received a copy of the GNU General Public License along
> - *  with this program; if not, write to the Free Software Foundation, Inc.,
> - *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + *  with this program; if not, see <https://www.gnu.org/licenses/>.
>    */
>   
>   #ifndef ASPEED_I2C_H
> diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h
> index b0f5204d80..8cdacbc4e1 100644
> --- a/include/hw/pci/pci_bridge.h
> +++ b/include/hw/pci/pci_bridge.h
> @@ -14,8 +14,8 @@
>    * GNU General Public License for more details.
>    *
>    * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> + * along with this program; if not, see
> + * <https://www.gnu.org/licenses/>.
>    *
>    * split out pci bus specific stuff from pci.[hc] to pci_bridge.[hc]
>    * Copyright (c) 2009 Isaku Yamahata <yamahata at valinux co jp>
> diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h
> index 767cae4b05..a850625a05 100644
> --- a/include/hw/timer/aspeed_timer.h
> +++ b/include/hw/timer/aspeed_timer.h
> @@ -16,8 +16,7 @@
>    *  GNU General Public License for more details.
>    *
>    *  You should have received a copy of the GNU General Public License along
> - *  with this program; if not, write to the Free Software Foundation, Inc.,
> - *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + *  with this program; if not, see <https://www.gnu.org/licenses/>.
>    */
>   #ifndef ASPEED_TIMER_H
>   #define ASPEED_TIMER_H


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.

Re: [PATCH 12/12] target/i386/emulate: replace FSF postal address with licenses URL

[Wei Liu]

On Fri, Jun 13, 2025 at 12:54:20PM -0400, Sean Wei wrote:
> Some of the LGPLv2.1 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>

It looks to me this is just following the footsteps of commit 8167ee883.

Reviewed-by: Wei Liu <wei.liu@kernel.org>

> ---
>  target/i386/emulate/x86_emu.c   | 4 ++--
>  target/i386/emulate/x86_flags.c | 4 ++--
>  target/i386/emulate/x86_flags.h | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c
> index 4890e0a4e5..db7a7f7437 100644
> --- a/target/i386/emulate/x86_emu.c
> +++ b/target/i386/emulate/x86_emu.c
> @@ -31,8 +31,8 @@
>  //  Lesser General Public License for more details.
>  //
>  //  You should have received a copy of the GNU Lesser General Public
> -//  License along with this library; if not, write to the Free Software
> -//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
> +//  License along with this library; if not, see
> +//  <https://www.gnu.org/licenses/>.
>  /////////////////////////////////////////////////////////////////////////
>  
>  #include "qemu/osdep.h"
> diff --git a/target/i386/emulate/x86_flags.c b/target/i386/emulate/x86_flags.c
> index cc138c7749..6592193b5e 100644
> --- a/target/i386/emulate/x86_flags.c
> +++ b/target/i386/emulate/x86_flags.c
> @@ -14,8 +14,8 @@
>  //  Lesser General Public License for more details.
>  //
>  //  You should have received a copy of the GNU Lesser General Public
> -//  License along with this library; if not, write to the Free Software
> -//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
> +//  License along with this library; if not, see
> +//  <https://www.gnu.org/licenses/>.
>  /////////////////////////////////////////////////////////////////////////
>  /*
>   * flags functions
> diff --git a/target/i386/emulate/x86_flags.h b/target/i386/emulate/x86_flags.h
> index 28b008e577..a395c837a0 100644
> --- a/target/i386/emulate/x86_flags.h
> +++ b/target/i386/emulate/x86_flags.h
> @@ -14,8 +14,8 @@
>  //  Lesser General Public License for more details.
>  //
>  //  You should have received a copy of the GNU Lesser General Public
> -//  License along with this library; if not, write to the Free Software
> -//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
> +//  License along with this library; if not, see
> +//  <https://www.gnu.org/licenses/>.
>  /////////////////////////////////////////////////////////////////////////
>  /*
>   * x86 eflags functions
> -- 
> 2.49.0
> 

Re: [PATCH 01/12] COPYING: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.33, Sean Wei wrote:
> The license text in COPYING (GPLv2), COPYING.LIB (LGPLv2.1),
> and the linux-headers/LICENSES/preferred/GPL-2.0 file are
> referenced to the obsolete FSF postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   COPYING                                  | 5 ++---
>   COPYING.LIB                              | 5 ++---
>   linux-headers/LICENSES/preferred/GPL-2.0 | 5 ++---
>   3 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/COPYING b/COPYING
> index 00ccfbb628..8095135d50 100644
> --- a/COPYING
> +++ b/COPYING
> @@ -2,7 +2,7 @@
>   		       Version 2, June 1991
>   
>    Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
> - 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + <https://fsf.org/>
>    Everyone is permitted to copy and distribute verbatim copies
>    of this license document, but changing it is not allowed.
>   
> @@ -304,8 +304,7 @@ the "copyright" line and a pointer to where the full notice is found.
>       GNU General Public License for more details.
>   
>       You should have received a copy of the GNU General Public License along
> -    with this program; if not, write to the Free Software Foundation, Inc.,
> -    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +    with this program; if not, see <https://www.gnu.org/licenses/>.
>   
>   Also add information on how to contact you by electronic and paper mail.
>   
> diff --git a/COPYING.LIB b/COPYING.LIB
> index 4362b49151..99f47575b5 100644
> --- a/COPYING.LIB
> +++ b/COPYING.LIB
> @@ -2,7 +2,7 @@
>                          Version 2.1, February 1999
>   
>    Copyright (C) 1991, 1999 Free Software Foundation, Inc.
> - 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
> + <https://fsf.org/>
>    Everyone is permitted to copy and distribute verbatim copies
>    of this license document, but changing it is not allowed.
>   
> @@ -484,8 +484,7 @@ convey the exclusion of warranty; and each file should have at least the
>       Lesser General Public License for more details.
>   
>       You should have received a copy of the GNU Lesser General Public
> -    License along with this library; if not, write to the Free Software
> -    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
> +    License along with this library; if not, see <https://www.gnu.org/licenses/>.
>   
>   Also add information on how to contact you by electronic and paper mail.
>   
> diff --git a/linux-headers/LICENSES/preferred/GPL-2.0 b/linux-headers/LICENSES/preferred/GPL-2.0
> index ff0812fd89..10248a619e 100644
> --- a/linux-headers/LICENSES/preferred/GPL-2.0
> +++ b/linux-headers/LICENSES/preferred/GPL-2.0

The files in linux-headers are sync'ed by the script 
scripts/update-linux-headers.sh ... so these changes will be reverted the 
next time someone runs the script. I'd suggest to drop this part of the 
patch - if you feel like contributing a patch to the Linux kernel, you could 
fix it there instead.

  Thomas

Re: [PATCH 02/12] linux-headers: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.38, Sean Wei wrote:
> The GPLv2 boiler-plate in asm-arm/kvm.h and asm-powerpc/kvm.h still
> contained the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   linux-headers/asm-arm/kvm.h     | 4 ++--
>   linux-headers/asm-powerpc/kvm.h | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-headers/asm-arm/kvm.h b/linux-headers/asm-arm/kvm.h
> index 0db5644e27..a8bb1aa42a 100644
> --- a/linux-headers/asm-arm/kvm.h
> +++ b/linux-headers/asm-arm/kvm.h
> @@ -13,8 +13,8 @@
>    * GNU General Public License for more details.
>    *
>    * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> + * along with this program; if not, see
> + * <https://www.gnu.org/licenses/>.
>    */
>   
>   #ifndef __ARM_KVM_H__
> diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm.h
> index eaeda00178..83faa7fae3 100644
> --- a/linux-headers/asm-powerpc/kvm.h
> +++ b/linux-headers/asm-powerpc/kvm.h
> @@ -10,8 +10,8 @@
>    * GNU General Public License for more details.
>    *
>    * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> + * along with this program; if not, see
> + * <https://www.gnu.org/licenses/>.
>    *
>    * Copyright IBM Corp. 2007
>    *

This also has to be fixed in the Linux kernel first, otherwise the changes 
will be reverted when someone runs the scripts/update-linux-headers.sh 
script. Sorry, I should have mentioned that in the 
https://gitlab.com/qemu-project/qemu/-/issues/2974 ticket, but I missed it, 
sorry!

  Thomas

Re: [PATCH 03/12] libdecnumber: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.39, Sean Wei wrote:
> Some of the GPLv2 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   libdecnumber/decContext.c     | 5 ++---
>   libdecnumber/decNumber.c      | 5 ++---
>   libdecnumber/dpd/decimal128.c | 5 ++---
>   libdecnumber/dpd/decimal32.c  | 5 ++---
>   libdecnumber/dpd/decimal64.c  | 5 ++---
>   5 files changed, 10 insertions(+), 15 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 04/12] include/libdecnumber: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.43, Sean Wei wrote:
> Some of the GPLv2 boiler-plate still contained the
> obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   include/libdecnumber/dconfig.h             | 5 ++---
>   include/libdecnumber/decContext.h          | 5 ++---
>   include/libdecnumber/decDPD.h              | 5 ++---
>   include/libdecnumber/decNumber.h           | 5 ++---
>   include/libdecnumber/decNumberLocal.h      | 5 ++---
>   include/libdecnumber/dpd/decimal128.h      | 5 ++---
>   include/libdecnumber/dpd/decimal128Local.h | 5 ++---
>   include/libdecnumber/dpd/decimal32.h       | 5 ++---
>   include/libdecnumber/dpd/decimal64.h       | 5 ++---
>   9 files changed, 18 insertions(+), 27 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 06/12] include/qemu: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.46, Sean Wei wrote:
> The LGPLv2.1 boiler-plate in rcu.h and rcu_queue.h still
> contained the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   include/qemu/rcu.h       | 4 ++--
>   include/qemu/rcu_queue.h | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 07/12] util/rcu.c: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.46, Sean Wei wrote:
> The LGPLv2.1 boiler-plate in util/rcu.c still contained
> the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   util/rcu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/util/rcu.c b/util/rcu.c
> index fa32c942e4..b703c86f15 100644
> --- a/util/rcu.c
> +++ b/util/rcu.c
> @@ -20,8 +20,8 @@
>    * Lesser General Public License for more details.
>    *
>    * You should have received a copy of the GNU Lesser General Public
> - * License along with this library; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + * License along with this library; if not, see
> + * <https://www.gnu.org/licenses/>.
>    *
>    * IBM's contributions to this file may be relicensed under LGPLv2 or later.
>    */

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 08/12] hw: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.50, Sean Wei wrote:
> The GPLv2 boiler-plate in vmxnet3.h and vmw_pvscsi.h still
> contained the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   hw/net/vmxnet3.h     | 4 ++--
>   hw/scsi/vmw_pvscsi.h | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 09/12] scripts: replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.51, Sean Wei wrote:
> The GPLv2 boiler-plate in scripts/device-crash-test still
> contained the obsolete "51 Franklin Street" postal address.
> 
> Replace it with the canonical GNU licenses URL recommended by the FSF:
> https://www.gnu.org/licenses/
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   scripts/device-crash-test | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/device-crash-test b/scripts/device-crash-test
> index da8b56edd9..1ecb9663ae 100755
> --- a/scripts/device-crash-test
> +++ b/scripts/device-crash-test
> @@ -16,8 +16,7 @@
>   # GNU General Public License for more details.
>   #
>   # You should have received a copy of the GNU General Public License along
> -# with this program; if not, write to the Free Software Foundation, Inc.,
> -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +# with this program; if not, see <https://www.gnu.org/licenses/>.
>   
>   """
>   Run QEMU with all combinations of -machine and -device types,

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 00/12] Replace FSF postal address with licenses URL

[Thomas Huth]

On 13/06/2025 18.30, Sean Wei wrote:
> The boiler-plate licence headers in several parts of QEMU still contain
> the obsolete “51 Franklin Street" contact line.
> 
> The Free Software Foundation now recommends using the canonical URL:
> 
>      https://www.gnu.org/licenses/
> 
> 
> This patch updates those headers. The patches are comment-only;
> no source code changes.
> 
> Please review and let me know if any patch should be split, squashed
> or dropped. This is my first patch for the QEMU project, so any
> feedback is greatly appreciated.
> 
> Thanks to Thomas Huth <thuth@redhat.com> for proposing this issue and
> outlining the steps, and to Daniel P. Berrangé <berrange@redhat.com>
> for the clarifications.
> 
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2438

It's rather https://gitlab.com/qemu-project/qemu/-/issues/2974 instead, but 
anyway, thanks for tackling this!

I'll queue the patches (except the one that updates linux-headers) for my 
next pull request.

  Thomas