From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: David Edmondson <david.edmondson@oracle.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>
Subject: Re: [PATCH v3 6/8] migration: Dump sub-cmd name in loadvm_process_command tp
Date: Thu, 30 Dec 2021 16:58:21 +0100 [thread overview]
Message-ID: <b5e38221-e7c9-587c-e86e-e3b5ce223b54@redhat.com> (raw)
In-Reply-To: <20211224065000.97572-7-peterx@redhat.com>
On 12/24/21 07:49, Peter Xu wrote:
> It'll be easier to read the name rather than index of sub-cmd when debugging.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/savevm.c | 3 ++-
> migration/trace-events | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/migration/trace-events b/migration/trace-events
> index b48d873b8a..d63a5915f5 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -22,7 +22,7 @@ loadvm_postcopy_handle_resume(void) ""
> loadvm_postcopy_ram_handle_discard(void) ""
> loadvm_postcopy_ram_handle_discard_end(void) ""
> loadvm_postcopy_ram_handle_discard_header(const char *ramid, uint16_t len) "%s: %ud"
> -loadvm_process_command(uint16_t com, uint16_t len) "com=0x%x len=%d"
> +loadvm_process_command(const char *s, uint16_t len) "com=%s len=%d"
Also: len=%u
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-12-30 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 6:49 [PATCH v3 0/8] migration: Postcopy cleanup on ram disgard Peter Xu
2021-12-24 6:49 ` [PATCH v3 1/8] migration: Drop dead code of ram_debug_dump_bitmap() Peter Xu
2021-12-30 15:53 ` Philippe Mathieu-Daudé
2021-12-24 6:49 ` [PATCH v3 2/8] migration: Don't return for postcopy_chunk_hostpages() Peter Xu
2021-12-30 15:53 ` Philippe Mathieu-Daudé
2021-12-24 6:49 ` [PATCH v3 3/8] migration: Drop postcopy_chunk_hostpages() Peter Xu
2021-12-24 6:49 ` [PATCH v3 4/8] migration: Do chunk page in postcopy_each_ram_send_discard() Peter Xu
2021-12-24 6:49 ` [PATCH v3 5/8] migration: Drop return code for disgard ram process Peter Xu
2021-12-30 16:03 ` Philippe Mathieu-Daudé
2021-12-24 6:49 ` [PATCH v3 6/8] migration: Dump sub-cmd name in loadvm_process_command tp Peter Xu
2021-12-24 10:56 ` David Edmondson
2021-12-30 15:58 ` Philippe Mathieu-Daudé [this message]
2021-12-24 6:49 ` [PATCH v3 7/8] migration: Finer grained tracepoints for POSTCOPY_LISTEN Peter Xu
2021-12-24 10:56 ` David Edmondson
2021-12-30 15:56 ` Philippe Mathieu-Daudé
2021-12-24 6:50 ` [PATCH v3 8/8] migration: Tracepoint change in postcopy-run bottom half Peter Xu
2021-12-24 10:57 ` David Edmondson
2021-12-30 15:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e38221-e7c9-587c-e86e-e3b5ce223b54@redhat.com \
--to=philmd@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).