From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL 23/27] i386: enable rust hpet for pc when rust is enabled
Date: Mon, 17 Feb 2025 14:15:01 +0100 [thread overview]
Message-ID: <b5eb1cf5-da20-49f9-8663-c5d27e00378c@redhat.com> (raw)
In-Reply-To: <Z7MXkxoMC/xpLiL2@intel.com>
On 2/17/25 12:03, Zhao Liu wrote:
> Hi Paolo,
>
>> --- a/hw/timer/Kconfig
>> +++ b/hw/timer/Kconfig
>> @@ -11,7 +11,7 @@ config A9_GTIMER
>>
>> config HPET
>> bool
>> - default y if PC
>> + default y if PC && !HAVE_RUST
>
> +
> +config X_HPET_RUST
> + bool
> + default y if PC && HAVE_RUST
>
>> config I8254
>> bool
>
> This patch doesn't enable the configuration option of Rust HPET for PC.
>
> Is it because the Rust HPET would break live migration, so we have to
> disable it?
No, something like this is missing:
diff --git a/rust/hw/timer/Kconfig b/rust/hw/timer/Kconfig
index afd98033503..42e421317a5 100644
--- a/rust/hw/timer/Kconfig
+++ b/rust/hw/timer/Kconfig
@@ -1,2 +1,3 @@
config X_HPET_RUST
bool
+ default y if PC && HAVE_RUST
I haven't checked if this passes CI yet.
Paolo
next prev parent reply other threads:[~2025-02-17 13:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 16:00 [PULL 00/27] rust, Windows patches for 2025-02-13 Paolo Bonzini
2025-02-13 16:00 ` [PULL 01/27] rust: docs: document naming convention Paolo Bonzini
2025-02-13 16:00 ` [PULL 02/27] rust: qom: add reference counting functionality Paolo Bonzini
2025-02-13 16:00 ` [PULL 03/27] rust: qom: add object creation functionality Paolo Bonzini
2025-02-13 16:00 ` [PULL 04/27] rust: callbacks: allow passing optional callbacks as () Paolo Bonzini
2025-02-13 16:00 ` [PULL 05/27] rust: qdev: add clock creation Paolo Bonzini
2025-02-13 16:00 ` [PULL 06/27] rust: qom: allow initializing interface vtables Paolo Bonzini
2025-02-13 16:00 ` [PULL 07/27] rust: qdev: make ObjectImpl a supertrait of DeviceImpl Paolo Bonzini
2025-02-13 16:00 ` [PULL 08/27] rust: qdev: switch from legacy reset to Resettable Paolo Bonzini
2025-02-13 16:00 ` [PULL 09/27] rust: bindings: add Send and Sync markers for types that have bindings Paolo Bonzini
2025-02-13 16:00 ` [PULL 10/27] rust: bindings for MemoryRegionOps Paolo Bonzini
2025-02-13 16:00 ` [PULL 11/27] rust: irq: define ObjectType for IRQState Paolo Bonzini
2025-02-13 16:00 ` [PULL 12/27] rust: chardev, qdev: add bindings to qdev_prop_set_chr Paolo Bonzini
2025-02-13 16:00 ` [PULL 13/27] rust: pl011: convert pl011_create to safe Rust Paolo Bonzini
2025-02-13 16:00 ` [PULL 14/27] i386/fw_cfg: move hpet_cfg definition to hpet.c Paolo Bonzini
2025-02-13 16:00 ` [PULL 15/27] rust/qdev: add the macro to define bit property Paolo Bonzini
2025-02-13 16:00 ` [PULL 16/27] rust/irq: Add a helper to convert [InterruptSource] to pointer Paolo Bonzini
2025-02-13 16:00 ` [PULL 17/27] rust: add bindings for gpio_{in|out} initialization Paolo Bonzini
2025-02-13 16:00 ` [PULL 18/27] rust: add bindings for memattrs Paolo Bonzini
2025-02-13 16:00 ` [PULL 19/27] rust: add bindings for timer Paolo Bonzini
2025-02-13 16:00 ` [PULL 20/27] rust/timer/hpet: define hpet_fw_cfg Paolo Bonzini
2025-02-13 16:00 ` [PULL 21/27] rust/timer/hpet: add basic HPET timer and HPETState Paolo Bonzini
2025-02-13 16:00 ` [PULL 22/27] rust/timer/hpet: add qom and qdev APIs support Paolo Bonzini
2025-02-13 16:00 ` [PULL 23/27] i386: enable rust hpet for pc when rust is enabled Paolo Bonzini
2025-02-17 11:03 ` Zhao Liu
2025-02-17 13:15 ` Paolo Bonzini [this message]
2025-02-13 16:00 ` [PULL 24/27] rust: qemu_api: add a documentation header for all modules Paolo Bonzini
2025-02-13 16:00 ` [PULL 25/27] rust: vmstate: remove redundant link targets Paolo Bonzini
2025-02-13 16:00 ` [PULL 26/27] rust: fix doctests Paolo Bonzini
2025-02-13 16:00 ` [PULL 27/27] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure Paolo Bonzini
2025-02-15 17:35 ` Michael Tokarev
2025-02-17 18:21 ` Paolo Bonzini
2025-02-14 16:58 ` [PULL 00/27] rust, Windows patches for 2025-02-13 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5eb1cf5-da20-49f9-8663-c5d27e00378c@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).