From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
"Jose R . Ziviani" <jziviani@suse.de>,
John Snow <jsnow@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH-for-6.2 2/2] hw/display: Do not allow multiple identical VGA devices
Date: Fri, 19 Nov 2021 10:20:20 +0100 [thread overview]
Message-ID: <b6034e95-2bc7-e720-7b03-4e3a48118226@redhat.com> (raw)
In-Reply-To: <20211118192020.61245-3-philmd@redhat.com>
On 11/18/21 20:20, Philippe Mathieu-Daudé wrote:
> + if (obj) {
> + const char *typename = object_get_typename(obj);
> +
> + /*
> + * make sure this device is not being added twice,
> + * if so exit without crashing qemu
> + */
> + if (object_resolve_path_type("", typename, NULL)) {
> + error_setg(errp, "at most one %s device is permitted", typename);
> + return false;
> + }
> + }
> +
Wouldn't it give the same error with one ISA and one PCI VGA?
Paolo
next prev parent reply other threads:[~2021-11-19 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 19:20 [PATCH-for-6.2 0/2] hw/display: Do not allow multiple (identical) VGA devices Philippe Mathieu-Daudé
2021-11-18 19:20 ` [PATCH-for-6.2 1/2] hw/display: Add Error* handle to vga_common_init() Philippe Mathieu-Daudé
2021-11-18 19:20 ` [PATCH-for-6.2 2/2] hw/display: Do not allow multiple identical VGA devices Philippe Mathieu-Daudé
2021-11-19 9:20 ` Paolo Bonzini [this message]
2021-11-19 9:42 ` Philippe Mathieu-Daudé
2021-11-19 10:10 ` Daniel P. Berrangé
2021-11-19 8:21 ` [PATCH-for-6.2 0/2] hw/display: Do not allow multiple (identical) " Mark Cave-Ayland
2021-11-19 9:49 ` Philippe Mathieu-Daudé
2021-11-19 9:58 ` Thomas Huth
2021-11-19 10:17 ` Philippe Mathieu-Daudé
2021-11-19 11:10 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6034e95-2bc7-e720-7b03-4e3a48118226@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=jziviani@suse.de \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).