From: Thomas Huth <thuth@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function
Date: Tue, 23 Jan 2024 07:03:03 +0100 [thread overview]
Message-ID: <b60d2855-8275-41d0-b5eb-e9912749b4f1@redhat.com> (raw)
In-Reply-To: <343c59db-8004-4461-9c9e-976ca2f1a357@weilnetz.de>
On 22/01/2024 21.59, Stefan Weil wrote:
> Am 22.01.24 um 20:17 schrieb Thomas Huth:
>
>> It is not used in QEMU - and if somebody needs this functionality,
>> they can simply use g_uri_escape_string() from the glib instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> include/qemu/uri.h | 1 -
>> util/uri.c | 64 ----------------------------------------------
>> 2 files changed, 65 deletions(-)
>
>
> The removed function is used in util/uri.c, so this patch breaks the
> compilation.
>
> That can be fixed by applying patch 4 before this one.
>
> With that re-ordering you may add my signature:
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
D'oh, I originally developed the patches the other way round indeed, but
then thought it would be nicer for review this way and swapped the order
without checking :-( ... I'll swap it back again.
Thanks!
Thomas
next prev parent reply other threads:[~2024-01-23 6:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 19:17 [PATCH 0/5] util/uri: Simplify the code, remove unused functions Thomas Huth
2024-01-22 19:17 ` [PATCH 1/5] util/uri: Remove the unused "target" argument from uri_string_unescape() Thomas Huth
2024-01-22 20:45 ` Stefan Weil via
2024-01-23 5:45 ` Philippe Mathieu-Daudé
2024-01-22 19:17 ` [PATCH 2/5] util/uri: Simplify uri_string_unescape() Thomas Huth
2024-01-22 21:22 ` Stefan Weil via
2024-01-23 6:01 ` Thomas Huth
2024-01-23 10:25 ` Paolo Bonzini
2024-01-23 11:21 ` Thomas Huth
2024-01-22 19:17 ` [PATCH 3/5] util/uri: Remove the uri_string_escape() function Thomas Huth
2024-01-22 20:59 ` Stefan Weil via
2024-01-23 6:03 ` Thomas Huth [this message]
2024-01-22 19:17 ` [PATCH 4/5] util/uri: Remove unused functions uri_resolve() and uri_resolve_relative() Thomas Huth
2024-01-22 21:03 ` Stefan Weil via
2024-01-22 19:17 ` [PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM() Thomas Huth
2024-01-22 21:04 ` Stefan Weil via
2024-01-23 5:50 ` Philippe Mathieu-Daudé
2024-01-22 19:22 ` [PATCH 0/5] util/uri: Simplify the code, remove unused functions Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60d2855-8275-41d0-b5eb-e9912749b4f1@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).