From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: rjones@redhat.com, peterz@infradead.org, arnd@arndb.de,
naresh.kamboju@linaro.org, anders.roxell@linaro.org,
daniel.diaz@linaro.org, ben.copeland@linaro.org,
pbonzini@redhat.com, Liren Wei <lrwei@bupt.edu.cn>
Subject: Re: [PATCH 2/2] accel/tcg: Always lock pages before translation
Date: Fri, 7 Jul 2023 09:05:35 +0100 [thread overview]
Message-ID: <b61fedbe-b7d8-e354-430d-db593151912e@linaro.org> (raw)
In-Reply-To: <20230706170537.95959-3-richard.henderson@linaro.org>
On 7/6/23 18:05, Richard Henderson wrote:
> +++ b/accel/tcg/cpu-exec.c
> @@ -531,6 +531,10 @@ static void cpu_exec_longjmp_cleanup(CPUState *cpu)
> /* Non-buggy compilers preserve this; assert the correct value. */
> g_assert(cpu == current_cpu);
>
> + if (tcg_ctx->gen_tb) {
> + tb_unlock_pages(tcg_ctx->gen_tb);
> + tcg_ctx->gen_tb = NULL;
> + }
Ho hum, fails for user-only, since there is one tcg_ctx and this cpu didn't necessarily
own it. Just a slight tweak needed, I'm sure.
r~
prev parent reply other threads:[~2023-07-07 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 17:05 [PATCH 0/2] accel/tcg: Fix race condition in tb create/invalidate Richard Henderson
2023-07-06 17:05 ` [PATCH 1/2] accel/tcg: Split out cpu_exec_longjmp_cleanup Richard Henderson
2023-07-06 17:46 ` Richard W.M. Jones
2023-07-07 8:09 ` Philippe Mathieu-Daudé
2023-07-07 10:37 ` Richard Henderson
2023-07-06 17:05 ` [PATCH 2/2] accel/tcg: Always lock pages before translation Richard Henderson
2023-07-06 19:33 ` Richard W.M. Jones
2023-07-07 8:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b61fedbe-b7d8-e354-430d-db593151912e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=ben.copeland@linaro.org \
--cc=daniel.diaz@linaro.org \
--cc=lrwei@bupt.edu.cn \
--cc=naresh.kamboju@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).