From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: anjo@rev.ng, philmd@linaro.org
Subject: Re: [PATCH v2 5/5] disas: Move disas.c into the target-independent source set
Date: Wed, 10 May 2023 08:53:16 +0200 [thread overview]
Message-ID: <b62ab9a2-fad5-313f-518c-29626b0d57c3@redhat.com> (raw)
In-Reply-To: <20230509163326.121090-6-richard.henderson@linaro.org>
On 09/05/2023 18.33, Richard Henderson wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> By using target_words_bigendian() instead of an ifdef,
> we can build this code once.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> [rth: Type change done in a separate patch]
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
...
> diff --git a/disas/meson.build b/disas/meson.build
> index f40230c58f..2ae44691fa 100644
> --- a/disas/meson.build
> +++ b/disas/meson.build
> @@ -13,4 +13,5 @@ common_ss.add(when: 'CONFIG_XTENSA_DIS', if_true: files('xtensa.c'))
> common_ss.add(when: capstone, if_true: [files('capstone.c'), capstone])
>
> softmmu_ss.add(files('disas-mon.c'))
> -specific_ss.add(files('disas.c'), capstone)
> +common_ss.add(files('disas.c'), capstone)
I guess you could drop the "capstone" here now since it is already added to
common_ss now three lines earlier.
Thomas
next prev parent reply other threads:[~2023-05-10 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:33 [PATCH v2 0/5] Make the core disassembler functions target-independent Richard Henderson
2023-05-09 16:33 ` [PATCH v2 1/5] disas: Move disas.c to disas/ Richard Henderson
2023-05-10 15:12 ` Philippe Mathieu-Daudé
2023-05-09 16:33 ` [PATCH v2 2/5] disas: Remove target_ulong from the interface Richard Henderson
2023-05-10 6:48 ` Thomas Huth
2023-05-09 16:33 ` [PATCH v2 3/5] disas: Remove target-specific headers Richard Henderson
2023-05-09 16:33 ` [PATCH v2 4/5] disas: Move softmmu specific code to separate file Richard Henderson
2023-05-09 16:33 ` [PATCH v2 5/5] disas: Move disas.c into the target-independent source set Richard Henderson
2023-05-10 6:53 ` Thomas Huth [this message]
2023-05-10 7:46 ` Richard Henderson
2023-05-10 8:10 ` Thomas Huth
2023-05-10 8:13 ` Richard Henderson
2023-05-10 15:19 ` Philippe Mathieu-Daudé
2023-05-10 6:54 ` [PATCH v2 0/5] Make the core disassembler functions target-independent Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b62ab9a2-fad5-313f-518c-29626b0d57c3@redhat.com \
--to=thuth@redhat.com \
--cc=anjo@rev.ng \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).