From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-devel for-3.1?] [PATCH] egl-headless: add egl_create_context
Date: Thu, 29 Nov 2018 08:09:56 -0600 [thread overview]
Message-ID: <b647b71a-ac53-f256-3e16-efa4806b4f7d@redhat.com> (raw)
In-Reply-To: <20181129123502.30129-1-kraxel@redhat.com>
On 11/29/18 6:35 AM, Gerd Hoffmann wrote:
> We must set the correct context (via eglMakeCurrent) before
> calling qemu_egl_create_context, so we need a thin wrapper and can't
> hook qemu_egl_create_context directly as ->dpy_gl_ctx_create callback.
>
> Reported-by: Frederik Carlier <frederik.carlier@quamotion.mobi>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/egl-headless.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
How severe is this? Is it something that would warrant 3.1-rc4, or are
we safe deferring it to 4.0?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-11-29 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 12:35 [Qemu-devel] [PATCH] egl-headless: add egl_create_context Gerd Hoffmann
2018-11-29 14:09 ` Eric Blake [this message]
2018-11-30 11:28 ` [Qemu-devel] [Qemu-devel for-3.1?] " Gerd Hoffmann
2018-12-03 15:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b647b71a-ac53-f256-3e16-efa4806b4f7d@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).