From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 09/11] qemu-iotests/139: Avoid blockdev-add with id
Date: Tue, 20 Sep 2016 16:33:34 -0500 [thread overview]
Message-ID: <b64f2e80-670b-9151-9f0f-d58450059a80@redhat.com> (raw)
In-Reply-To: <1474376602-9665-10-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On 09/20/2016 08:03 AM, Kevin Wolf wrote:
> We want to remove the 'id' option for blockdev-add. This removes one
> user of the option and makes it use only node names.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/139 | 178 +++++++++++++++------------------------------
> tests/qemu-iotests/139.out | 4 +-
> 2 files changed, 59 insertions(+), 123 deletions(-)
>
> @@ -1,5 +1,5 @@
> -............
> +.........
> ----------------------------------------------------------------------
> -Ran 12 tests
> +Ran 9 tests
Might be worth expanding the commit message to mention that deleted test
cases are intentional (similar to the longer message in 2/11).
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-20 21:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 13:03 [Qemu-devel] [PATCH v2 00/11] block: Remove BB interface from blockdev-add/del Kevin Wolf
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 01/11] qemu-iotests/041: Avoid blockdev-add with id Kevin Wolf
2016-09-20 20:22 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 02/11] qemu-iotests/067: " Kevin Wolf
2016-09-20 20:25 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 03/11] qemu-iotests/071: " Kevin Wolf
2016-09-20 20:26 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 04/11] qemu-iotests/081: " Kevin Wolf
2016-09-20 20:28 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 05/11] qemu-iotests/087: " Kevin Wolf
2016-09-20 20:33 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 06/11] qemu-iotests/117: " Kevin Wolf
2016-09-20 21:03 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 07/11] qemu-iotests/118: " Kevin Wolf
2016-09-20 21:20 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 08/11] qemu-iotests/124: " Kevin Wolf
2016-09-20 21:27 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 09/11] qemu-iotests/139: " Kevin Wolf
2016-09-20 21:33 ` Eric Blake [this message]
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 10/11] qemu-iotests/141: " Kevin Wolf
2016-09-20 21:35 ` Eric Blake
2016-09-20 13:03 ` [Qemu-devel] [PATCH v2 11/11] block: Remove BB interface from blockdev-add/del Kevin Wolf
2016-09-20 21:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64f2e80-670b-9151-9f0f-d58450059a80@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).