From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gp77o-0003uU-EA for qemu-devel@nongnu.org; Thu, 31 Jan 2019 02:51:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gp77m-0007xT-Hm for qemu-devel@nongnu.org; Thu, 31 Jan 2019 02:51:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34032) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gp77m-0007gw-8C for qemu-devel@nongnu.org; Thu, 31 Jan 2019 02:51:02 -0500 References: <20190131073234.18037-1-yang.zhong@intel.com> <20190131073234.18037-3-yang.zhong@intel.com> From: Thomas Huth Message-ID: Date: Thu, 31 Jan 2019 08:50:34 +0100 MIME-Version: 1.0 In-Reply-To: <20190131073234.18037-3-yang.zhong@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 02/27] ide: split ioport registration to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Zhong , qemu-devel@nongnu.org Cc: pbonzini@redhat.com On 2019-01-31 08:32, Yang Zhong wrote: > From: Paolo Bonzini > > This is not needed on ARM, and brings in ISA bus code which is otherwise not > necessary. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/Makefile.objs | 4 +-- > hw/ide/core.c | 25 ----------------- > hw/ide/ioport.c | 66 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 68 insertions(+), 27 deletions(-) > create mode 100644 hw/ide/ioport.c Reviewed-by: Thomas Huth