From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v3 6/8] tests/acceptance: Do not set the machine type manually
Date: Mon, 30 Dec 2019 12:10:46 -0200 [thread overview]
Message-ID: <b67d94e6-5e27-766f-46e8-65a1416508aa@redhat.com> (raw)
In-Reply-To: <20191229224505.24466-7-f4bug@amsat.org>
On 12/29/19 8:45 PM, Philippe Mathieu-Daudé wrote:
> Since commit ba21bde93 we don't need to set the machine type
> manually, the one set by the ":avocado: tags=machine" will be used.
Correct.
>
> Suggested-by: Cleber Rosa <crosa@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/acceptance/machine_avr6.py | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py
> index 7a7d8afc29..394b3d4f8f 100644
> --- a/tests/acceptance/machine_avr6.py
> +++ b/tests/acceptance/machine_avr6.py
> @@ -45,7 +45,6 @@ class AVR6Machine(Test):
> rom_hash = '7eb521f511ca8f2622e0a3c5e8dd686efbb911d4'
> rom_path = self.fetch_asset(rom_url, asset_hash=rom_hash)
>
> - self.vm.set_machine('sample')
> self.vm.add_args('-bios', rom_path)
> self.vm.add_args('-nographic')
> self.vm.launch()
next prev parent reply other threads:[~2019-12-30 14:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 22:44 [PATCH v3 0/8] hw/avr: Introduce the Arduino boards Philippe Mathieu-Daudé
2019-12-29 22:44 ` [PATCH v3 1/8] hw/char/avr: Reduce USART I/O size Philippe Mathieu-Daudé
2019-12-29 22:44 ` [PATCH v3 2/8] hw/timer/avr_timer16: Rename memory region debugging name Philippe Mathieu-Daudé
2019-12-29 22:45 ` [PATCH v3 3/8] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2019-12-29 22:45 ` [PATCH v3 4/8] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-20 9:03 ` Igor Mammedov
2020-01-20 9:21 ` Philippe Mathieu-Daudé
2020-01-20 10:09 ` Igor Mammedov
2020-01-20 11:05 ` Philippe Mathieu-Daudé
2020-01-20 14:48 ` Igor Mammedov
2019-12-29 22:45 ` [PATCH v3 5/8] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2019-12-29 22:45 ` [PATCH v3 6/8] tests/acceptance: Do not set the machine type manually Philippe Mathieu-Daudé
2019-12-30 14:10 ` Wainer dos Santos Moschetta [this message]
2019-12-29 22:45 ` [PATCH v3 7/8] tests/acceptance: Keep multilines comment consistent with other tests Philippe Mathieu-Daudé
2019-12-29 22:45 ` [PATCH v3 8/8] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2019-12-29 22:57 ` [PATCH v3 0/8] hw/avr: Introduce the Arduino boards no-reply
2019-12-29 23:18 ` Philippe Mathieu-Daudé
2019-12-30 18:17 ` Michael Rolnik
2020-01-19 22:50 ` Philippe Mathieu-Daudé
2020-01-20 5:29 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67d94e6-5e27-766f-46e8-65a1416508aa@redhat.com \
--to=wainersm@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mrolnik@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).