From: Thomas Huth <thuth@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, danielhb@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
Date: Mon, 6 Nov 2017 12:58:16 +0100 [thread overview]
Message-ID: <b691e0e4-0131-202a-feb2-97659816477b@redhat.com> (raw)
In-Reply-To: <20171106115347.19873-1-marcandre.lureau@redhat.com>
On 06.11.2017 12:53, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> default-configs/arm-softmmu.mak | 2 ++
> default-configs/i386-softmmu.mak | 1 +
> default-configs/x86_64-softmmu.mak | 1 +
> hw/misc/Makefile.objs | 2 +-
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
> CONFIG_ASPEED_SOC=y
> CONFIG_GPIO_KEY=y
> CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y
Maybe remove the empty line?
Apart from that, patch looks good to me, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-11-06 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 11:53 [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets Marc-André Lureau
2017-11-06 11:58 ` Thomas Huth [this message]
2017-11-06 12:04 ` Marc-André Lureau
2017-11-06 12:40 ` Daniel Henrique Barboza
2017-11-15 13:18 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b691e0e4-0131-202a-feb2-97659816477b@redhat.com \
--to=thuth@redhat.com \
--cc=danielhb@linux.vnet.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).