* [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
@ 2017-11-06 11:53 Marc-André Lureau
2017-11-06 11:58 ` Thomas Huth
2017-11-06 12:40 ` Daniel Henrique Barboza
0 siblings, 2 replies; 5+ messages in thread
From: Marc-André Lureau @ 2017-11-06 11:53 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, thuth, danielhb, Marc-André Lureau
vmcoreinfo is built for all targets. However, it requires fw_cfg with
DMA operations support (write operation). Restrict vmcoreinfo exposure
to architectures that are supporting FW_CFG_DMA, that is arm-virt and
x86 only atm.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
default-configs/arm-softmmu.mak | 2 ++
default-configs/i386-softmmu.mak | 1 +
default-configs/x86_64-softmmu.mak | 1 +
hw/misc/Makefile.objs | 2 +-
4 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 5059d134c8..d37edc4312 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
CONFIG_ASPEED_SOC=y
CONFIG_GPIO_KEY=y
CONFIG_MSF2=y
+
+CONFIG_FW_CFG_DMA=y
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index a685c439e7..95ac4b464a 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
CONFIG_PXB=y
CONFIG_ACPI_VMGENID=y
+CONFIG_FW_CFG_DMA=y
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
index ea69e8289e..0221236825 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
CONFIG_PXB=y
CONFIG_ACPI_VMGENID=y
+CONFIG_FW_CFG_DMA=y
diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
index 19202d90cf..10c88a84b4 100644
--- a/hw/misc/Makefile.objs
+++ b/hw/misc/Makefile.objs
@@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
common-obj-$(CONFIG_EDU) += edu.o
common-obj-y += unimp.o
-common-obj-y += vmcoreinfo.o
+common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
obj-$(CONFIG_VMPORT) += vmport.o
--
2.15.0.rc0.40.gaefcc5f6f
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
2017-11-06 11:53 [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets Marc-André Lureau
@ 2017-11-06 11:58 ` Thomas Huth
2017-11-06 12:04 ` Marc-André Lureau
2017-11-06 12:40 ` Daniel Henrique Barboza
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-11-06 11:58 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: mst, danielhb
On 06.11.2017 12:53, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> default-configs/arm-softmmu.mak | 2 ++
> default-configs/i386-softmmu.mak | 1 +
> default-configs/x86_64-softmmu.mak | 1 +
> hw/misc/Makefile.objs | 2 +-
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
> CONFIG_ASPEED_SOC=y
> CONFIG_GPIO_KEY=y
> CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y
Maybe remove the empty line?
Apart from that, patch looks good to me, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
2017-11-06 11:58 ` Thomas Huth
@ 2017-11-06 12:04 ` Marc-André Lureau
0 siblings, 0 replies; 5+ messages in thread
From: Marc-André Lureau @ 2017-11-06 12:04 UTC (permalink / raw)
To: Thomas Huth; +Cc: QEMU, Daniel Henrique Barboza, Michael S. Tsirkin
Hi
On Mon, Nov 6, 2017 at 12:58 PM, Thomas Huth <thuth@redhat.com> wrote:
> On 06.11.2017 12:53, Marc-André Lureau wrote:
>> vmcoreinfo is built for all targets. However, it requires fw_cfg with
>> DMA operations support (write operation). Restrict vmcoreinfo exposure
>> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
>> x86 only atm.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> default-configs/arm-softmmu.mak | 2 ++
>> default-configs/i386-softmmu.mak | 1 +
>> default-configs/x86_64-softmmu.mak | 1 +
>> hw/misc/Makefile.objs | 2 +-
>> 4 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
>> index 5059d134c8..d37edc4312 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>> CONFIG_ASPEED_SOC=y
>> CONFIG_GPIO_KEY=y
>> CONFIG_MSF2=y
>> +
>> +CONFIG_FW_CFG_DMA=y
>
> Maybe remove the empty line?
>
This file seems to be organized somehow, although it's hard to figure
out how for me at first glance ;) commenting sections would help.
> Apart from that, patch looks good to me, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
2017-11-06 11:53 [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets Marc-André Lureau
2017-11-06 11:58 ` Thomas Huth
@ 2017-11-06 12:40 ` Daniel Henrique Barboza
2017-11-15 13:18 ` Marc-André Lureau
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Henrique Barboza @ 2017-11-06 12:40 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: thuth, mst
On 11/06/2017 09:53 AM, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Tested-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
> default-configs/arm-softmmu.mak | 2 ++
> default-configs/i386-softmmu.mak | 1 +
> default-configs/x86_64-softmmu.mak | 1 +
> hw/misc/Makefile.objs | 2 +-
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
> CONFIG_ASPEED_SOC=y
> CONFIG_GPIO_KEY=y
> CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index a685c439e7..95ac4b464a 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
> CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
> CONFIG_PXB=y
> CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> index ea69e8289e..0221236825 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
> CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
> CONFIG_PXB=y
> CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index 19202d90cf..10c88a84b4 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
> common-obj-$(CONFIG_EDU) += edu.o
>
> common-obj-y += unimp.o
> -common-obj-y += vmcoreinfo.o
> +common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>
> obj-$(CONFIG_VMPORT) += vmport.o
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets
2017-11-06 12:40 ` Daniel Henrique Barboza
@ 2017-11-15 13:18 ` Marc-André Lureau
0 siblings, 0 replies; 5+ messages in thread
From: Marc-André Lureau @ 2017-11-15 13:18 UTC (permalink / raw)
To: Daniel Henrique Barboza; +Cc: QEMU, Thomas Huth, Michael S. Tsirkin
Michael,
Could you pick this patch for 2.11 ?
thanks
On Mon, Nov 6, 2017 at 1:40 PM, Daniel Henrique Barboza
<danielhb@linux.vnet.ibm.com> wrote:
>
>
> On 11/06/2017 09:53 AM, Marc-André Lureau wrote:
>>
>> vmcoreinfo is built for all targets. However, it requires fw_cfg with
>> DMA operations support (write operation). Restrict vmcoreinfo exposure
>> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
>> x86 only atm.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>
>
> Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
> Tested-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
>
>
>> default-configs/arm-softmmu.mak | 2 ++
>> default-configs/i386-softmmu.mak | 1 +
>> default-configs/x86_64-softmmu.mak | 1 +
>> hw/misc/Makefile.objs | 2 +-
>> 4 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak
>> b/default-configs/arm-softmmu.mak
>> index 5059d134c8..d37edc4312 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>> CONFIG_ASPEED_SOC=y
>> CONFIG_GPIO_KEY=y
>> CONFIG_MSF2=y
>> +
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/default-configs/i386-softmmu.mak
>> b/default-configs/i386-softmmu.mak
>> index a685c439e7..95ac4b464a 100644
>> --- a/default-configs/i386-softmmu.mak
>> +++ b/default-configs/i386-softmmu.mak
>> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>> CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>> CONFIG_PXB=y
>> CONFIG_ACPI_VMGENID=y
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/default-configs/x86_64-softmmu.mak
>> b/default-configs/x86_64-softmmu.mak
>> index ea69e8289e..0221236825 100644
>> --- a/default-configs/x86_64-softmmu.mak
>> +++ b/default-configs/x86_64-softmmu.mak
>> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>> CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>> CONFIG_PXB=y
>> CONFIG_ACPI_VMGENID=y
>> +CONFIG_FW_CFG_DMA=y
>> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
>> index 19202d90cf..10c88a84b4 100644
>> --- a/hw/misc/Makefile.objs
>> +++ b/hw/misc/Makefile.objs
>> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
>> common-obj-$(CONFIG_EDU) += edu.o
>> common-obj-y += unimp.o
>> -common-obj-y += vmcoreinfo.o
>> +common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>> obj-$(CONFIG_VMPORT) += vmport.o
>>
>
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-15 13:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 11:53 [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets Marc-André Lureau
2017-11-06 11:58 ` Thomas Huth
2017-11-06 12:04 ` Marc-André Lureau
2017-11-06 12:40 ` Daniel Henrique Barboza
2017-11-15 13:18 ` Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).