From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 7/7] target/arm: Remove ARCH macro
Date: Tue, 4 Aug 2020 20:07:11 -0700 [thread overview]
Message-ID: <b6a1d0c5-30ad-f6c5-8919-a76b9591b4fe@linaro.org> (raw)
In-Reply-To: <20200803111849.13368-8-peter.maydell@linaro.org>
On 8/3/20 4:18 AM, Peter Maydell wrote:
> The ARCH() macro was used a lot in the legacy decoder, but
> there are now just two uses of it left. Since a macro which
> expands out to a goto is liable to be confusing when reading
> code, replace the last two uses with a simple open-coded
> qeuivalent.
^^^
typo
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/translate.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-08-05 3:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 11:18 [PATCH 0/7] target/arm: copro decode cleanup Peter Maydell
2020-08-03 11:18 ` [PATCH 1/7] target/arm: Pull handling of XScale insns out of disas_coproc_insn() Peter Maydell
2020-08-04 14:49 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 2/7] target/arm: Separate decode from handling of coproc insns Peter Maydell
2020-08-04 14:53 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 3/7] target/arm: Convert A32 coprocessor insns to decodetree Peter Maydell
2020-08-05 2:53 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 4/7] target/arm: Tidy up disas_arm_insn() Peter Maydell
2020-08-05 2:57 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 5/7] target/arm: Do M-profile NOCP checks early and via decodetree Peter Maydell
2020-08-05 3:04 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 6/7] target/arm: Convert T32 coprocessor insns to decodetree Peter Maydell
2020-08-05 3:05 ` Richard Henderson
2020-08-03 11:18 ` [PATCH 7/7] target/arm: Remove ARCH macro Peter Maydell
2020-08-05 3:07 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a1d0c5-30ad-f6c5-8919-a76b9591b4fe@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).