From: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Den Lunev <den@openvz.org>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread
Date: Wed, 24 Mar 2021 10:48:04 +0300 [thread overview]
Message-ID: <b6aef92d-2545-ecb8-c20f-1c43367badc8@virtuozzo.com> (raw)
In-Reply-To: <20210323183537.GH6486@xz-x1>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On 23.03.2021 21:35, Peter Xu wrote:
> On Tue, Mar 23, 2021 at 08:21:43PM +0300, Andrey Gruzdev wrote:
>>> For the long term I think we'd better have a helper:
>>>
>>> qemu_put_qio_channel_buffer(QEMUFile *file, QIOChannelBuffer *bioc)
>>>
>>> So as to hide this flush operation, which is tricky. We'll have two users so
>>> far:
>>>
>>> bg_migration_completion
>>> colo_do_checkpoint_transaction
>>>
>>> IMHO it'll be nicer if you'd do it in this patch altogether!
>>>
>>> Thanks,
>>>
>> Sorry, can't get the idea, what's wrong with the fix.
> I'm fine with the fix, but I've got one patch attached just to show what I
> meant, so without any testing for sure..
>
> Looks more complicated than I thought, but again I think we should hide that
> buffer flush into another helper to avoid overlooking it.
Thanks, Peter, now I've got what you meant - not to overlook flush on buffer channel.
But it seems that adding a reasonable comment is enough here.
>
> Thanks,
>
[-- Attachment #2: Type: text/html, Size: 1653 bytes --]
next prev parent reply other threads:[~2021-03-24 7:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 14:52 [PATCH v1 0/3] migration: Fixes to the 'background-snapshot' code Andrey Gruzdev
2021-03-19 14:52 ` [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread Andrey Gruzdev
2021-03-22 20:17 ` Peter Xu
2021-03-23 7:51 ` Andrey Gruzdev
2021-03-23 14:54 ` Peter Xu
2021-03-23 17:21 ` Andrey Gruzdev
2021-03-23 18:35 ` Peter Xu
2021-03-24 7:48 ` Andrey Gruzdev [this message]
2021-03-24 17:35 ` Dr. David Alan Gilbert
2021-03-24 18:50 ` Peter Xu
2021-03-19 14:52 ` [PATCH v1 2/3] migration: Inhibit virtio-balloon for the duration of background snapshot Andrey Gruzdev
2021-03-19 14:52 ` [PATCH v1 3/3] migration: Pre-fault memory before starting background snasphot Andrey Gruzdev
2021-03-23 22:21 ` [PATCH v1 0/3] migration: Fixes to the 'background-snapshot' code Peter Xu
2021-03-24 8:09 ` Andrey Gruzdev
2021-03-24 15:41 ` Peter Xu
2021-03-25 9:51 ` Andrey Gruzdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6aef92d-2545-ecb8-c20f-1c43367badc8@virtuozzo.com \
--to=andrey.gruzdev@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).