From: Richard Henderson <richard.henderson@linaro.org>
To: Stafford Horne <shorne@gmail.com>, qemu-devel@nongnu.org
Cc: famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements
Date: Mon, 2 Jul 2018 07:26:26 -0700 [thread overview]
Message-ID: <b6bd1555-1bc3-f7f4-ec3c-e6dfceee6507@linaro.org> (raw)
In-Reply-To: <20180702120119.GP24595@lianli.shorne-pla.net>
On 07/02/2018 05:01 AM, Stafford Horne wrote:
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #129: FILE: target/openrisc/disas.c:56:
>> + arg_l_##opcode *a, uint32_t insn) \
>> ^
>>
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #224: FILE: target/openrisc/disas.c:151:
>> + arg_lf_##opcode##_##suffix *a, uint32_t insn) \
>> ^
>
> I have fixed these on my branch.
These should not have been "fixed".
This is checkpatch being stupid and not realizing that
the thing on the left is a type and this is a pointer
declaration, not a multiplication.
r~
next prev parent reply other threads:[~2018-07-02 14:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 3:03 [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 01/23] target/openrisc: Fix mtspr shadow gprs Richard Henderson
2018-06-28 14:10 ` Philippe Mathieu-Daudé
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 02/23] target/openrisc: Add print_insn_or1k Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 03/23] target/openrisc: Log interrupts Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 04/23] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 05/23] target/openrisc: Use exit_tb instead of CPU_INTERRUPT_EXITTB Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 06/23] target/openrisc: Fix singlestep_enabled Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 07/23] target/openrisc: Link more translation blocks Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 08/23] target/openrisc: Split out is_user Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 09/23] target/openrisc: Exit the TB after l.mtspr Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 10/23] target/openrisc: Form the spr index from tcg Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 11/23] target/openrisc: Merge tlb allocation into CPUOpenRISCState Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 12/23] target/openrisc: Remove indirect function calls for mmu Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 13/23] target/openrisc: Merge mmu_helper.c into mmu.c Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 14/23] target/openrisc: Reduce tlb to a single dimension Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 15/23] target/openrisc: Fix tlb flushing in mtspr Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 16/23] target/openrisc: Fix cpu_mmu_index Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 17/23] target/openrisc: Use identical sizes for ITLB and DTLB Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 18/23] target/openrisc: Stub out handle_mmu_fault for softmmu Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 19/23] target/openrisc: Increase the TLB size Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 20/23] target/openrisc: Reorg tlb lookup Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 21/23] target/openrisc: Add support in scripts/qemu-binfmt-conf.sh Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 22/23] linux-user: Implement signals for openrisc Richard Henderson
2018-06-28 3:03 ` [Qemu-devel] [PATCH v3 23/23] linux-user: Fix struct sigaltstack " Richard Henderson
2018-06-28 21:31 ` [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements Stafford Horne
2018-07-02 12:27 ` Peter Maydell
2018-07-02 2:39 ` no-reply
2018-07-02 12:01 ` Stafford Horne
2018-07-02 14:26 ` Richard Henderson [this message]
2018-07-02 14:39 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bd1555-1bc3-f7f4-ec3c-e6dfceee6507@linaro.org \
--to=richard.henderson@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).