Re: [Qemu-devel] [PATCH 11/13] hw/rdma: Print backend QP number in hex format

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 07/16/2018 10:40 AM, Yuval Shaia wrote:
> To be consistent with other prints throughout the code fix places that
> print it as decimal number.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>   hw/rdma/rdma_rm.c           | 4 ++--
>   hw/rdma/vmw/pvrdma_qp_ops.c | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
> index 1f014b4ab2..859c900003 100644
> --- a/hw/rdma/rdma_rm.c
> +++ b/hw/rdma/rdma_rm.c
> @@ -389,7 +389,7 @@ int rdma_rm_modify_qp(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev,
>       RdmaRmQP *qp;
>       int ret;
>   
> -    pr_dbg("qpn=%d\n", qp_handle);
> +    pr_dbg("qpn=0x%x\n", qp_handle);
>   
>       qp = rdma_rm_get_qp(dev_res, qp_handle);
>       if (!qp) {
> @@ -447,7 +447,7 @@ int rdma_rm_query_qp(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev,
>   {
>       RdmaRmQP *qp;
>   
> -    pr_dbg("qpn=%d\n", qp_handle);
> +    pr_dbg("qpn=0x%x\n", qp_handle);
>   
>       qp = rdma_rm_get_qp(dev_res, qp_handle);
>       if (!qp) {
> diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
> index a8664f40c8..c668afd0ed 100644
> --- a/hw/rdma/vmw/pvrdma_qp_ops.c
> +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
> @@ -130,7 +130,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>       PvrdmaSqWqe *wqe;
>       PvrdmaRing *ring;
>   
> -    pr_dbg("qp_handle=%d\n", qp_handle);
> +    pr_dbg("qp_handle=0x%x\n", qp_handle);
>   
>       qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle);
>       if (unlikely(!qp)) {
> @@ -174,7 +174,7 @@ int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle)
>       PvrdmaRqWqe *wqe;
>       PvrdmaRing *ring;
>   
> -    pr_dbg("qp_handle=%d\n", qp_handle);
> +    pr_dbg("qp_handle=0x%x\n", qp_handle);
>   
>       qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle);
>       if (unlikely(!qp)) {

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel