Re: [Qemu-devel] [Qemu-block] [PATCH] nbd: Fix iotests failure due to changed client error message

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

On 07/17/2017 01:12 PM, John Snow wrote:
> 
> 
> On 07/17/2017 10:23 AM, Eric Blake wrote:
>> Commit 8ecaeae8 changed the way the client requests an NBD export,
>> and in the process also changed the resulting error message when
>> the export is not present, breaking a couple of iotests.  The error
>> message is now directly given by the server (a failed NBD_OPT_GO)
>> instead of implied by the client (after exhausting NBD_OPT_LIST),
>> but looking at the testsuite changes, it proves worthwhile to
>> reword the error message to be slightly less verbose (as this is
>> one particular error message likely to be hit by a user).
>>
>> Note that the error message is now sensitive to which binary is
>> running the server as well as the client (since the expected
>> output is replaying a message received from the server); in

also depends on the server being new enough to understand NBD_OPT_GO.
I'll tweak the commit message before sending the pull request

>> general iotests are run on client and server from the same source
>> code base, but if it proves problematic in practice, we'll have
>> to tweak or sanitize the output somehow.
>>
>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
> 
> Thanks, fixes it up for me.
> 
> Tested-by: John Snow <jsnow@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>

Thanks; queued on my NBD branch:
git://repo.or.cz/qemu/ericb.git nbd

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]