qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Stefan Weil" <sw@weilnetz.de>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Cc: Helge Deller <deller@gmx.de>,
	Peter Maydell <peter.maydell@linaro.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures
Date: Wed, 10 Apr 2019 08:07:52 +0200	[thread overview]
Message-ID: <b6df5f4b-d567-bab0-fb9d-78ca20154ec7@redhat.com> (raw)
In-Reply-To: <a53b3bab-5aa4-b37f-f194-7788bce1d04b@weilnetz.de>

On 09/04/2019 21.46, Stefan Weil wrote:
> On 05.04.19 11:16, Philippe Mathieu-Daudé wrote:
>> On 4/5/19 11:02 AM, Daniel P. Berrangé wrote:
>>> On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote:
>>> Do the various crashes that you illustrate in that cover letter
>>> still exist today ? If so, 2 years of continued brokenness with no
>>> fixes would reinforce the the view that it is time to remove TCI
>>> from the codebase.
>>
>> Or find a maintainer and add tests...
> 
> Thank you for CC'ing me. I could not spend much of my free time for QEMU
> last year and typically will miss important messages on the list unless
> my address is explicitly given. Nevertheless I still feel responsible
> for TCI, and I am also listed as maintainer in MAINTAINERS.

That's great, good to know that you're still interested in TCI! ... but
I think one of the main problems is still that we completely lack test
coverage for TCI - the code always is in danger to bit-rot if it is not
tested by default.

I could maybe have a try to add some test to our .gitlab-ci.yml file ...
if you or somebody else could add one to .travis.yml, that would be
great. Something like:

 - ./configure --enable-tcg-interpreter --target-list=alpha-softmmu,ppc64-softmmu,i386-softmmu,sparc-softmmu,microblaze-softmmu,moxie-softmmu,arm-softmmu,hppa-softmmu
 - make
 - make tests/boot-serial-test
 - QTEST_QEMU_BINARY="alpha-softmmu/qemu-system-alpha"  ./tests/boot-serial-test
 - QTEST_QEMU_BINARY="ppc64-softmmu/qemu-system-ppc64"  ./tests/boot-serial-test
 - ...

 Thomas

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: "Stefan Weil" <sw@weilnetz.de>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Helge Deller <deller@gmx.de>, Michael Tokarev <mjt@tls.msk.ru>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures
Date: Wed, 10 Apr 2019 08:07:52 +0200	[thread overview]
Message-ID: <b6df5f4b-d567-bab0-fb9d-78ca20154ec7@redhat.com> (raw)
Message-ID: <20190410060752.FVfYr7cJXbDeHGD_d_n9G0PD4TAHxNOUwa82mG14stw@z> (raw)
In-Reply-To: <a53b3bab-5aa4-b37f-f194-7788bce1d04b@weilnetz.de>

On 09/04/2019 21.46, Stefan Weil wrote:
> On 05.04.19 11:16, Philippe Mathieu-Daudé wrote:
>> On 4/5/19 11:02 AM, Daniel P. Berrangé wrote:
>>> On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote:
>>> Do the various crashes that you illustrate in that cover letter
>>> still exist today ? If so, 2 years of continued brokenness with no
>>> fixes would reinforce the the view that it is time to remove TCI
>>> from the codebase.
>>
>> Or find a maintainer and add tests...
> 
> Thank you for CC'ing me. I could not spend much of my free time for QEMU
> last year and typically will miss important messages on the list unless
> my address is explicitly given. Nevertheless I still feel responsible
> for TCI, and I am also listed as maintainer in MAINTAINERS.

That's great, good to know that you're still interested in TCI! ... but
I think one of the main problems is still that we completely lack test
coverage for TCI - the code always is in danger to bit-rot if it is not
tested by default.

I could maybe have a try to add some test to our .gitlab-ci.yml file ...
if you or somebody else could add one to .travis.yml, that would be
great. Something like:

 - ./configure --enable-tcg-interpreter --target-list=alpha-softmmu,ppc64-softmmu,i386-softmmu,sparc-softmmu,microblaze-softmmu,moxie-softmmu,arm-softmmu,hppa-softmmu
 - make
 - make tests/boot-serial-test
 - QTEST_QEMU_BINARY="alpha-softmmu/qemu-system-alpha"  ./tests/boot-serial-test
 - QTEST_QEMU_BINARY="ppc64-softmmu/qemu-system-ppc64"  ./tests/boot-serial-test
 - ...

 Thomas


  parent reply	other threads:[~2019-04-10  6:08 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 18:57 [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures Helge Deller
2019-04-04 19:24 ` Philippe Mathieu-Daudé
2019-04-05  7:14   ` Helge Deller
2019-04-05  7:14     ` Helge Deller
2019-04-05  1:34 ` Peter Maydell
2019-04-05  1:34   ` Peter Maydell
2019-04-05  7:56   ` Helge Deller
2019-04-05  7:56     ` Helge Deller
2019-04-05  8:26     ` Daniel P. Berrangé
2019-04-05  8:26       ` Daniel P. Berrangé
2019-04-05  9:02       ` Helge Deller
2019-04-05  9:02         ` Helge Deller
2019-04-05  9:10         ` Philippe Mathieu-Daudé
2019-04-05  9:10           ` Philippe Mathieu-Daudé
2019-04-05  9:13         ` Peter Maydell
2019-04-05  9:13           ` Peter Maydell
2019-04-05  9:15         ` Daniel P. Berrangé
2019-04-05  9:15           ` Daniel P. Berrangé
2019-04-05  8:47     ` Philippe Mathieu-Daudé
2019-04-05  8:47       ` Philippe Mathieu-Daudé
2019-04-05  9:02       ` Daniel P. Berrangé
2019-04-05  9:02         ` Daniel P. Berrangé
2019-04-05  9:16         ` Philippe Mathieu-Daudé
2019-04-05  9:16           ` Philippe Mathieu-Daudé
2019-04-09 19:46           ` Stefan Weil
2019-04-09 19:46             ` Stefan Weil
2019-04-09 20:39             ` Richard Henderson
2019-04-09 20:39               ` Richard Henderson
2019-04-10  6:17               ` Stefan Weil
2019-04-10  6:17                 ` Stefan Weil
2019-04-11  6:21                 ` Richard Henderson
2019-04-11  6:21                   ` Richard Henderson
2019-04-10  6:07             ` Thomas Huth [this message]
2019-04-10  6:07               ` Thomas Huth
2019-04-10  6:24               ` Stefan Weil
2019-04-10  6:24                 ` Stefan Weil
2019-04-10  8:22               ` Thomas Huth
2019-04-10  8:22                 ` Thomas Huth
2019-04-10 19:22                 ` Stefan Weil
2019-04-10 19:22                   ` Stefan Weil
2019-04-10  7:48             ` Thomas Huth
2019-04-10  7:48               ` Thomas Huth
2019-04-06  8:59     ` Richard Henderson
2019-04-06  8:59       ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6df5f4b-d567-bab0-fb9d-78ca20154ec7@redhat.com \
    --to=thuth@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=deller@gmx.de \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).