qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 1/2] tests/functional: make tuxrun disk images writable
Date: Fri, 25 Oct 2024 13:28:01 +0200	[thread overview]
Message-ID: <b6f0f64b-5b9f-4bb8-b8e5-148c62651ab8@redhat.com> (raw)
In-Reply-To: <20241025092659.2312118-2-berrange@redhat.com>

On 25/10/2024 11.26, Daniel P. Berrangé wrote:
> The zstd command will preserve the input archive permissions on the
> output file. So when we decompress the readonly cached image, the
> resulting per-test run private disk image will also be readonly.
> We need it to be writable, so make it so.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/functional/qemu_test/tuxruntest.py | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)

Ah, so it was just about the new tuxrun tests that were likely not merged 
before ... Good to know that we can fix it in a central spot :-)

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2024-10-25 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  9:26 [PATCH v2 0/2] tests/functional: protect cached assets from modification Daniel P. Berrangé
2024-10-25  9:26 ` [PATCH v2 1/2] tests/functional: make tuxrun disk images writable Daniel P. Berrangé
2024-10-25 11:28   ` Thomas Huth [this message]
2024-10-25  9:26 ` [PATCH v2 2/2] tests/functional: make cached asset files read-only Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6f0f64b-5b9f-4bb8-b8e5-148c62651ab8@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).