From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D350CCFA13 for ; Sun, 9 Nov 2025 13:41:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vI5eS-0002Zx-I1; Sun, 09 Nov 2025 08:40:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vI5eQ-0002ZD-J0 for qemu-devel@nongnu.org; Sun, 09 Nov 2025 08:40:15 -0500 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vI5eO-0000UJ-Kt for qemu-devel@nongnu.org; Sun, 09 Nov 2025 08:40:14 -0500 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-b6d402422c2so443455666b.2 for ; Sun, 09 Nov 2025 05:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762695611; x=1763300411; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FGGWXmu/Gp5QZI1NAlHAkNxYhkYxP1TdvMJCl4NIAwI=; b=wR1ssRj9AzOnB5arTnhLfwEcv8KZxRK1Rrjnp1WFKQTzAhJV2KT/pPzseenQYXQVNG Ei3A78EsLS9f5CrdKDv7DPSwZO+feobqnnXPh8M69/f3HNXPFHDs9mf75OB079AHmcOn 0eBfYPopcXCN1irVc9TkmCnEKrKiamCHlGttiA8HIaK9U4grG+O3pOtp38Bbrfy1Jawv n6yXyDyDNYh6xp/ZWSkhQpaDFnYJq5HfCnldw8Nly9E8Ic61TRYwebTb5GgfDhks24KA NWFaSMoz6/gQQANPeoDf6hSvYp4+zsC3tiy+ef0Rn56OWkOqub6RcazQ+jQ/QBA960kn +VmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762695611; x=1763300411; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FGGWXmu/Gp5QZI1NAlHAkNxYhkYxP1TdvMJCl4NIAwI=; b=hbZ9CIxAszZeRNr/QaOhaEf95X11TePr/Cy6Jcbi0401woHHvDINiONDxD/U6OdFLg qcpnyDRWf2+RW1M/Q2YxuFKeHmsDsGBw2n9iKyvKK6a3FPrYVmFBGskkc4CThgzk9dO6 vQNTP7llfYMMUHFd36QDGE7Ybaq4cqmubjUYANzm39lHM5PDcW+lGcV6IpIIfxV2NPqt NgRg1tW+QhuqzOXhr+0d8zF0HfPHGGjbb1OZMm8trs5tfUeDuYb40oAcWfmoNwhxIpG3 GkRpyf57ITbzkGWBbqxyKBTL8iVdjzibGZXvf/TACBib2CdfOlnXg9Lz1Ew2AtcRvmY5 T5ug== X-Forwarded-Encrypted: i=1; AJvYcCXraNUQBNaSURK8coLg1n8lCu8YF45/GZGxo3mLITInZLkwAzxP/wHzDQu6BPkcaK/GhPI/T1KFzDaJ@nongnu.org X-Gm-Message-State: AOJu0Yx54C3SwYXXO1VcezpO3Dl8ZwfxnZmFz96hPB+nD9e9/mYtvR9y /Pih0hPMpMZZiGqsSCoo/3d87ePagyJPssAScCr76JT0iLsGw51xJq1cwZH87njZXbo= X-Gm-Gg: ASbGncvAGQLU9RhWhMi031C8WcmeCjeV2gA/Yi+sIla58/1AgXLznGbYKNgLzkqTd1K SFbLAESe02tIQ0Cs27KSEzhrxEe7NtZovWjgZHg3cDAzz9FJzlJJnkuFvDJBVA2B4ZW35EIhMxD jecor/RsPgHCBpX6ig8OWPxhoTUHg3KYfDm1KQz8RSi8QOP6C9BmhWjy3ga5hGM4jq19uBvXy+5 ZuQjB74CamYh7ktC6zTQNcO1n5XGb4kb0kANdgYvuCH3YBgNdJobbfsDuuh/synW9qLxxkX3XPK 7Dtq8EbRGUUIg8GbrJ+tJfFbUnfv7agsdCrTLmYmS2+0HR7vErgd7Kzr2n2H1+9bwIAA432QndT upWvahI9NKTnZSDxhX86g88QcPyX977iK9Btlk9ZdDFB7evzdZNtWfYbVK76S6OAzqRpakyxxAK kjYFbM16YnbLGZWOvo8CsJMCZSWq6Hp5O93fDr3NQppPZy+6/JbIoYRI6f2w== X-Google-Smtp-Source: AGHT+IGXWcafAtkvpfqSQj5CLPxLhG6iz+bmK+NVtdOrflDHP2NhzUIFdlIk6YTgWBr7onfep3XNzQ== X-Received: by 2002:a17:907:7e91:b0:b6d:9576:3890 with SMTP id a640c23a62f3a-b72e04ca2a7mr522352466b.45.1762695610760; Sun, 09 Nov 2025 05:40:10 -0800 (PST) Received: from [192.168.2.7] (tmo-086-152.customers.d1-online.com. [80.187.86.152]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bfa24d2asm795825666b.70.2025.11.09.05.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Nov 2025 05:40:08 -0800 (PST) Message-ID: Date: Sun, 9 Nov 2025 14:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] hw/display/xlnx_dp: Don't abort for unsupported graphics formats Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Alistair Francis , "Edgar E. Iglesias" References: <20251106145209.1083998-1-peter.maydell@linaro.org> <20251106145209.1083998-3-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251106145209.1083998-3-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::644; envelope-from=philmd@linaro.org; helo=mail-ej1-x644.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On 6/11/25 15:52, Peter Maydell wrote: > If the guest writes an invalid or unsupported value to the > AV_BUF_FORMAT register, currently we abort(). Instead, log this as > either a guest error or an unimplemented error and continue. > > The existing code treats DP_NL_VID_CB_Y0_CR_Y1 as x8b8g8r8 > via a "case 0" that does not use the enum constant name for some > reason; we leave that alone beyond adding a comment about the > weird code. > > Documentation of this register seems to be at: > https://docs.amd.com/r/en-US/ug1087-zynq-ultrascale-registers/AV_BUF_FORMAT-DISPLAY_PORT-Register > > Cc: qemu-stable@nongnu.org > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1415 > Signed-off-by: Peter Maydell > --- > hw/display/xlnx_dp.c | 53 +++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 48 insertions(+), 5 deletions(-) > > diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c > index c2bf692e7b1..d8119a56292 100644 > --- a/hw/display/xlnx_dp.c > +++ b/hw/display/xlnx_dp.c > @@ -665,14 +665,28 @@ static void xlnx_dp_change_graphic_fmt(XlnxDPState *s) > case DP_GRAPHIC_BGR888: > s->g_plane.format = PIXMAN_b8g8r8; > break; > + case DP_GRAPHIC_RGBA5551: > + case DP_GRAPHIC_RGBA4444: > + case DP_GRAPHIC_8BPP: > + case DP_GRAPHIC_4BPP: > + case DP_GRAPHIC_2BPP: > + case DP_GRAPHIC_1BPP: > + qemu_log_mask(LOG_UNIMP, "%s: unimplemented graphic format %u", > + __func__, > + s->avbufm_registers[AV_BUF_FORMAT] & DP_GRAPHIC_MASK); > + s->g_plane.format = PIXMAN_r8g8b8a8; > + break; > default: > - error_report("%s: unsupported graphic format %u", __func__, > - s->avbufm_registers[AV_BUF_FORMAT] & DP_GRAPHIC_MASK); > + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid graphic format %u", > + __func__, > + s->avbufm_registers[AV_BUF_FORMAT] & DP_GRAPHIC_MASK); > + s->g_plane.format = PIXMAN_r8g8b8a8; > abort(); Don't we want to remove this abort() call? Otherwise, Reviewed-by: Philippe Mathieu-Daudé > }