From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] softfloat: add float128_is_{normal, denormal}
Date: Wed, 6 Feb 2019 09:39:46 +0000 [thread overview]
Message-ID: <b70f98e5-6309-1cb1-6d11-1eaaeff8fc4e@linaro.org> (raw)
In-Reply-To: <20190206091043.10985-1-david@redhat.com>
On 2/6/19 9:10 AM, David Hildenbrand wrote:
> Needed on s390x, to test for the data class of a number. So it will
> gain soon a user.
>
> A number is considered normal if the exponent is neither 0 nor all 1's.
> That can be checked by adding 1 to the exponent, and comparing against
>> = 2 after dropping an eventual overflow into the sign bit.
> While at it, convert the other floatXX_is_normal functions to use a
> similar, less error prone calculation, as suggested by Richard H.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/fpu/softfloat.h | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-02-06 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 9:10 [Qemu-devel] [PATCH v2] softfloat: add float128_is_{normal, denormal} David Hildenbrand
2019-02-06 9:39 ` Richard Henderson [this message]
2019-02-06 14:25 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70f98e5-6309-1cb1-6d11-1eaaeff8fc4e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).