From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jcody@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 08/33] job: Rename BlockJobType into JobType
Date: Tue, 24 Apr 2018 17:12:32 -0500 [thread overview]
Message-ID: <b71fb9db-96ba-01df-3212-6bae5c11eb1e@redhat.com> (raw)
In-Reply-To: <20180424152515.25664-9-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On 04/24/2018 10:24 AM, Kevin Wolf wrote:
> QAPI types aren't externally visible, so we can rename them without
> causing problems. Before we add a job type to Job, rename the enum
> so it can be used for more than just block jobs.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-24 22:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:24 [Qemu-devel] [RFC PATCH 00/33] Generic background jobs Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 01/33] blockjob: Wrappers for progress counter access Kevin Wolf
2018-04-24 21:06 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 02/33] blockjob: Move RateLimit to BlockJob Kevin Wolf
2018-04-24 21:24 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 03/33] blockjob: Implement block_job_set_speed() centrally Kevin Wolf
2018-04-24 21:30 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 04/33] blockjob: Introduce block_job_ratelimit_get_delay() Kevin Wolf
2018-04-24 21:57 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 05/33] blockjob: Add block_job_driver() Kevin Wolf
2018-04-24 22:04 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 06/33] blockjob: Remove block_job_pause/resume_all() Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 07/33] job: Create Job, JobDriver and job_create() Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 08/33] job: Rename BlockJobType into JobType Kevin Wolf
2018-04-24 22:12 ` Eric Blake [this message]
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 09/33] job: Add JobDriver.job_type Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 10/33] job: Add job_delete() Kevin Wolf
2018-04-24 22:15 ` Eric Blake
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 11/33] job: Maintain a list of all jobs Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 12/33] job: Move state transitions to Job Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 13/33] job: Add reference counting Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 14/33] job: Move cancelled to Job Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 15/33] job: Add Job.aio_context Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 16/33] job: Move defer_to_main_loop to Job Kevin Wolf
2018-04-24 15:24 ` [Qemu-devel] [RFC PATCH 17/33] job: Move coroutine and related code " Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 18/33] job: Add job_sleep_ns() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 19/33] job: Move pause/resume functions to Job Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 20/33] job: Replace BlockJob.completed with job_is_completed() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 21/33] job: Move BlockJobCreateFlags to Job Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 22/33] blockjob: Split block_job_event_pending() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 23/33] job: Add job_event_*() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 24/33] job: Move single job finalisation to Job Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 25/33] job: Convert block_job_cancel_async() " Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 26/33] job: Add job_drain() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 27/33] job: Move .complete callback to Job Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 28/33] job: Move job_finish_sync() " Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 29/33] job: Switch transactions to JobTxn Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 30/33] job: Move transactions to Job Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 31/33] job: Move completion and cancellation " Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 32/33] job: Add job_yield() Kevin Wolf
2018-04-24 15:25 ` [Qemu-devel] [RFC PATCH 33/33] job: Add job_dismiss() Kevin Wolf
2018-04-24 16:25 ` [Qemu-devel] [RFC PATCH 00/33] Generic background jobs no-reply
2018-04-24 22:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71fb9db-96ba-01df-3212-6bae5c11eb1e@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).