From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH 4/4] linux-user/syscall: do_setsockopt(): eliminate goto in switch for SO_SNDTIMEO
Date: Tue, 2 Apr 2024 11:44:05 +0200 [thread overview]
Message-ID: <b729fa0e-7058-4ae0-8adb-fdd9a3f724da@linaro.org> (raw)
In-Reply-To: <20240331100737.2724186-5-mjt@tls.msk.ru>
On 31/3/24 12:07, Michael Tokarev wrote:
> There's identical code for SO_SNDTIMEO and SO_RCVTIMEO, currently
> implemented using an ugly goto into another switch case. Eliminate
> that using arithmetic if, making code flow more natural.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> linux-user/syscall.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-02 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 10:07 [PATCH 0/4] small linux-user/syscall:do_setsockopt() cleanups and fixes Michael Tokarev
2024-03-31 10:07 ` [PATCH v2 1/4] linux-user/syscall: do_setsockopt: fix SOL_ALG.ALG_SET_KEY Michael Tokarev
2024-03-31 10:07 ` [PATCH 2/4] linux-user/syscall: do_setsockopt(): make ip_mreq local to the place it is used and inline target_to_host_ip_mreq() Michael Tokarev
2024-03-31 10:07 ` [PATCH 3/4] linux-user/syscall: do_setsockopt(): make ip_mreq_source local to the place where it is used Michael Tokarev
2024-03-31 10:07 ` [PATCH 4/4] linux-user/syscall: do_setsockopt(): eliminate goto in switch for SO_SNDTIMEO Michael Tokarev
2024-04-02 9:44 ` Philippe Mathieu-Daudé [this message]
2024-04-05 22:35 ` [PATCH 0/4] small linux-user/syscall:do_setsockopt() cleanups and fixes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b729fa0e-7058-4ae0-8adb-fdd9a3f724da@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).