From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Fix more reference output files due to recent qemu-io change
Date: Tue, 7 May 2019 07:34:34 +0200 [thread overview]
Message-ID: <b731310f-24a3-9e0f-133a-b35d672ef1ea@redhat.com> (raw)
In-Reply-To: <423e6bb2-493f-991d-2d35-4a9f84093625@redhat.com>
On 06/05/2019 18.52, Eric Blake wrote:
> On 5/6/19 10:32 AM, Max Reitz wrote:
>> On 01.05.19 15:41, Thomas Huth wrote:
>>> The output of qemu-io changed recently - most tests have been fixed in
>>> commit 36b9986b08787019ef42 ("tests/qemu-iotests: Fix output of qemu-io
>>> related tests") already, but the qcow1 and the vmdk test was still missing.
>>>
>>> Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()")
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> tests/qemu-iotests/059.out | 8 ++++----
>>> tests/qemu-iotests/092.out | 24 ++++++++++++------------
>>> 2 files changed, 16 insertions(+), 16 deletions(-)
>>
>> Hmm, nbd's 083 is also broken. Would you mind fixing that, too? O:-)
>>
>
> See below for what to squash in. With that, I can give:
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> In fact, I don't mind taking it through my NBD tree, since there is at
> least one other iotest fix for NBD pending.
Thanks! I assume you can fix up the patch, or do you want me to resend it?
Thomas
prev parent reply other threads:[~2019-05-07 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 13:41 [Qemu-devel] [PATCH] tests/qemu-iotests: Fix more reference output files due to recent qemu-io change Thomas Huth
2019-05-01 13:41 ` Thomas Huth
2019-05-02 11:16 ` [Qemu-devel] [Qemu-block] " Stefano Garzarella
2019-05-02 11:16 ` Stefano Garzarella
2019-05-06 15:32 ` [Qemu-devel] " Max Reitz
2019-05-06 16:52 ` Eric Blake
2019-05-07 5:34 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b731310f-24a3-9e0f-133a-b35d672ef1ea@redhat.com \
--to=thuth@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).