From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>, Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] s390x: refactor reset/reipl handling
Date: Thu, 21 Jun 2018 18:59:45 +0200 [thread overview]
Message-ID: <b73a7220-62a2-4e85-0268-cd6c40ca3b24@redhat.com> (raw)
In-Reply-To: <eda9ada5-1fdd-1652-6cc8-0a3592dbf996@redhat.com>
On 21/06/2018 18:08, David Hildenbrand wrote:
>> Without this we have no kdump/kexec/ipl
>> as soon as somebody uses -no-reboot.
>>
> Paolo even said that consistent -no-reboot handling would be one of the
> benefits :)
>
kdump/kexec (and of course "ipl") do not reboot on x86, so fixing the
bug does help in making things consistent. :)
Do we really want a reset event for ipl? Maybe for kexec/kdump, but
perhaps just using SHUTDOWN_CAUSE_NONE for MODIFIED_CLEAR and
LOAD_NORMAL (not sure about the difference) is the way to go.
For example, x86 suspend is a "reboot" but it is already special cased
to use SHUTDOWN_CAUSE_NONE.
Paolo
next prev parent reply other threads:[~2018-06-21 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 10:18 [Qemu-devel] [PATCH v1] s390x: refactor reset/reipl handling David Hildenbrand
2018-04-26 9:50 ` Cornelia Huck
2018-05-09 14:15 ` David Hildenbrand
2018-05-09 14:36 ` Cornelia Huck
2018-05-09 16:56 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-05-14 9:24 ` [Qemu-devel] " Cornelia Huck
2018-06-21 15:49 ` Christian Borntraeger
2018-06-21 16:04 ` David Hildenbrand
2018-06-21 16:04 ` Cornelia Huck
2018-06-21 16:06 ` Christian Borntraeger
2018-06-21 16:08 ` David Hildenbrand
2018-06-21 16:59 ` Paolo Bonzini [this message]
2018-06-21 16:07 ` David Hildenbrand
2018-06-21 16:10 ` Christian Borntraeger
2018-06-21 16:15 ` David Hildenbrand
2018-06-21 16:20 ` Christian Borntraeger
2018-06-21 16:21 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-06-21 16:22 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b73a7220-62a2-4e85-0268-cd6c40ca3b24@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).