From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] qemu-img: Recognize no creation support in -o help
Date: Wed, 2 May 2018 13:40:06 -0400 [thread overview]
Message-ID: <b743804c-6532-3ad8-3d1e-5303686d10da@redhat.com> (raw)
In-Reply-To: <20180421165423.30759-6-mreitz@redhat.com>
On 04/21/2018 12:54 PM, Max Reitz wrote:
> The only users of print_block_option_help() are qemu-img create and
> qemu-img convert for the output image, so this function is always used
> for image creation (it used to be used for amendment also, but that is
> no longer the case).
>
> So if image creation is not supported by either the format or the
> protocol, there is no need to print any option description, because the
> user cannot create an image like this anyway.
>
> This also fixes an assertion failure:
>
> $ qemu-img create -f bochs -o help
> Supported options:
> qemu-img: util/qemu-option.c:219:
> qemu_opts_print_help: Assertion `list' failed.
> [1] 24831 abort (core dumped) qemu-img create -f bochs -o help
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
This is great.
3-5: Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2018-05-02 17:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 16:54 [Qemu-devel] [PATCH 0/7] qemu-img: Improve option help for amend Max Reitz
2018-04-21 16:54 ` [Qemu-devel] [PATCH 1/7] qemu-img: Amendment support implies create_opts Max Reitz
2018-05-02 17:35 ` Eric Blake
2018-04-21 16:54 ` [Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options Max Reitz
2018-05-01 22:49 ` [Qemu-devel] [Qemu-block] " John Snow
2018-05-02 17:52 ` [Qemu-devel] " Eric Blake
2018-05-02 18:08 ` Max Reitz
2018-04-21 16:54 ` [Qemu-devel] [PATCH 3/7] qemu-option: Pull out "Supported options" print Max Reitz
2018-05-02 18:09 ` Eric Blake
2018-04-21 16:54 ` [Qemu-devel] [PATCH 4/7] qemu-img: Add print_amend_option_help() Max Reitz
2018-05-02 18:13 ` Eric Blake
2018-04-21 16:54 ` [Qemu-devel] [PATCH 5/7] qemu-img: Recognize no creation support in -o help Max Reitz
2018-05-02 17:40 ` John Snow [this message]
2018-05-02 18:15 ` Eric Blake
2018-04-21 16:54 ` [Qemu-devel] [PATCH 6/7] iotests: Test help option for unsupporting formats Max Reitz
2018-05-02 18:00 ` [Qemu-devel] [Qemu-block] " John Snow
2018-05-02 18:17 ` [Qemu-devel] " Eric Blake
2018-04-21 16:54 ` [Qemu-devel] [PATCH 7/7] iotests: Rework 113 Max Reitz
2018-05-02 18:03 ` [Qemu-devel] [Qemu-block] " John Snow
2018-05-02 18:13 ` Max Reitz
2018-05-02 18:18 ` John Snow
2018-05-02 18:48 ` Max Reitz
2018-05-02 18:24 ` [Qemu-devel] " Eric Blake
2018-05-02 18:35 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b743804c-6532-3ad8-3d1e-5303686d10da@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).